From 7e9a970d1abd9b4956f62ade9ba6a30548883f64 Mon Sep 17 00:00:00 2001 From: Santiago Seifert Date: Wed, 5 Feb 2020 16:45:39 +0000 Subject: [PATCH 1/2] Fix MediaParser sniffing Change-Id: I053d06866b41925a04bb7ca506e30a4a6cb0c3ed Test: Pending Bug: 132153067 --- apex/media/framework/java/android/media/MediaParser.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apex/media/framework/java/android/media/MediaParser.java b/apex/media/framework/java/android/media/MediaParser.java index d59270c6a51b9..db84717be1b1f 100644 --- a/apex/media/framework/java/android/media/MediaParser.java +++ b/apex/media/framework/java/android/media/MediaParser.java @@ -15,6 +15,7 @@ */ package android.media; +import android.annotation.CheckResult; import android.annotation.NonNull; import android.annotation.Nullable; import android.net.Uri; @@ -382,6 +383,7 @@ public final class MediaParser { * parse the input. */ @NonNull + @CheckResult private static UnrecognizedInputFormatException createForExtractors( @NonNull String... extractorNames) { StringBuilder builder = new StringBuilder(); @@ -536,7 +538,7 @@ public final class MediaParser { } } if (mExtractor == null) { - UnrecognizedInputFormatException.createForExtractors(mExtractorNamesPool); + throw UnrecognizedInputFormatException.createForExtractors(mExtractorNamesPool); } return true; } From f1076aa80ad8a6da884d9a857bfccca83c59b957 Mon Sep 17 00:00:00 2001 From: Santiago Seifert Date: Wed, 5 Feb 2020 17:18:23 +0000 Subject: [PATCH 2/2] Add FlacExtractor to MediaParser Test: Pending Bug: 132153067 Change-Id: I4a53a0ccd652bf505708eed521ea45e52826a084 --- apex/media/framework/java/android/media/MediaParser.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apex/media/framework/java/android/media/MediaParser.java b/apex/media/framework/java/android/media/MediaParser.java index db84717be1b1f..96110e1541f88 100644 --- a/apex/media/framework/java/android/media/MediaParser.java +++ b/apex/media/framework/java/android/media/MediaParser.java @@ -33,6 +33,7 @@ import com.google.android.exoplayer2.extractor.PositionHolder; import com.google.android.exoplayer2.extractor.SeekMap.SeekPoints; import com.google.android.exoplayer2.extractor.TrackOutput; import com.google.android.exoplayer2.extractor.amr.AmrExtractor; +import com.google.android.exoplayer2.extractor.flac.FlacExtractor; import com.google.android.exoplayer2.extractor.flv.FlvExtractor; import com.google.android.exoplayer2.extractor.mkv.MatroskaExtractor; import com.google.android.exoplayer2.extractor.mp3.Mp3Extractor; @@ -914,6 +915,7 @@ public final class MediaParser { extractorFactoriesByName.put("exo.Ac4Extractor", Ac4Extractor::new); extractorFactoriesByName.put("exo.AdtsExtractor", AdtsExtractor::new); extractorFactoriesByName.put("exo.AmrExtractor", AmrExtractor::new); + extractorFactoriesByName.put("exo.FlacExtractor", FlacExtractor::new); extractorFactoriesByName.put("exo.FlvExtractor", FlvExtractor::new); extractorFactoriesByName.put("exo.FragmentedMp4Extractor", FragmentedMp4Extractor::new); extractorFactoriesByName.put("exo.MatroskaExtractor", MatroskaExtractor::new);