From 03f378d49570efa6df5fd0bbb4911b78d963aa3e Mon Sep 17 00:00:00 2001 From: Michael Mikhail Date: Wed, 9 Nov 2022 17:48:37 +0000 Subject: [PATCH] Enable testMediaRecommendationDisabled It simply removes @ignore and replaces the foreground executor with uiExecutor because it is the one used in removing the recommendation. Bug: 229838140 Test: atest MediaDataManagerTest. Test: checked via forrest/atest to make sure it is not flaky. Change-Id: I758a950a061c6bb20b9cc6a5484500a8609078a6 --- .../systemui/media/controls/pipeline/MediaDataManagerTest.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/SystemUI/tests/src/com/android/systemui/media/controls/pipeline/MediaDataManagerTest.kt b/packages/SystemUI/tests/src/com/android/systemui/media/controls/pipeline/MediaDataManagerTest.kt index 8bd71632638d4..52b694fac07c8 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/media/controls/pipeline/MediaDataManagerTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/media/controls/pipeline/MediaDataManagerTest.kt @@ -62,7 +62,6 @@ import com.android.systemui.util.time.FakeSystemClock import com.google.common.truth.Truth.assertThat import org.junit.After import org.junit.Before -import org.junit.Ignore import org.junit.Rule import org.junit.Test import org.junit.runner.RunWith @@ -806,7 +805,6 @@ class MediaDataManagerTest : SysuiTestCase() { .onSmartspaceMediaDataLoaded(anyObject(), anyObject(), anyBoolean()) } - @Ignore("b/229838140") @Test fun testMediaRecommendationDisabled_removesSmartspaceData() { // GIVEN a media recommendation card is present @@ -823,7 +821,9 @@ class MediaDataManagerTest : SysuiTestCase() { tunableCaptor.value.onTuningChanged(Settings.Secure.MEDIA_CONTROLS_RECOMMENDATION, "0") // THEN listeners are notified + uiExecutor.advanceClockToLast() foregroundExecutor.advanceClockToLast() + uiExecutor.runAllReady() foregroundExecutor.runAllReady() verify(listener).onSmartspaceMediaDataRemoved(eq(KEY_MEDIA_SMARTSPACE), eq(true)) }