From 54e221a4dfe879fe9165bc34517941c0dada6c8d Mon Sep 17 00:00:00 2001 From: Aurimas Liutikas Date: Tue, 9 May 2017 11:08:34 -0700 Subject: [PATCH] Fix broken android.view.DisabledTest. The test was calling setOnClickListener off the main thread. Test: ran manually and it now passes Bug: 38166715 Change-Id: I63777467a789c6a060b340d6b410ac2e744db678 --- .../src/android/view/DisabledTest.java | 39 +++++++++++-------- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/core/tests/coretests/src/android/view/DisabledTest.java b/core/tests/coretests/src/android/view/DisabledTest.java index 992c277e51d31..d78e5e9bcbbdb 100644 --- a/core/tests/coretests/src/android/view/DisabledTest.java +++ b/core/tests/coretests/src/android/view/DisabledTest.java @@ -16,15 +16,15 @@ package android.view; -import com.android.frameworks.coretests.R; -import android.test.TouchUtils; -import android.test.suitebuilder.annotation.MediumTest; -import android.test.suitebuilder.annotation.LargeTest; - import android.test.ActivityInstrumentationTestCase; -import android.widget.Button; +import android.test.TouchUtils; +import android.test.suitebuilder.annotation.LargeTest; +import android.test.suitebuilder.annotation.MediumTest; import android.view.KeyEvent; import android.view.View; +import android.widget.Button; + +import com.android.frameworks.coretests.R; /** * Exercises {@link android.view.View}'s disabled property. @@ -45,18 +45,23 @@ public class DisabledTest extends ActivityInstrumentationTestCase { final Disabled a = getActivity(); mDisabled = (Button) a.findViewById(R.id.disabledButton); - mDisabled.setOnClickListener(new View.OnClickListener() { - public void onClick(View v) { - mClicked = true; - } - }); - mDisabledParent = a.findViewById(R.id.clickableParent); - mDisabledParent.setOnClickListener(new View.OnClickListener() { - public void onClick(View v) { - mParentClicked = true; - } - }); + getInstrumentation().runOnMainSync( + new Runnable() { + @Override + public void run() { + mDisabled.setOnClickListener(new View.OnClickListener() { + public void onClick(View v) { + mClicked = true; + } + }); + mDisabledParent.setOnClickListener(new View.OnClickListener() { + public void onClick(View v) { + mParentClicked = true; + } + }); + } + }); } @Override