diff --git a/core/jni/com_android_internal_os_Zygote.cpp b/core/jni/com_android_internal_os_Zygote.cpp index a3f5311e49c46..58fd9c0ab85e8 100644 --- a/core/jni/com_android_internal_os_Zygote.cpp +++ b/core/jni/com_android_internal_os_Zygote.cpp @@ -74,6 +74,7 @@ #include #include #include +#include #include #include #include @@ -1673,9 +1674,14 @@ static void com_android_internal_os_Zygote_nativeEmptyUsapPool(JNIEnv* env, jcla static int disable_execute_only(struct dl_phdr_info *info, size_t size, void *data) { // Search for any execute-only segments and mark them read+execute. for (int i = 0; i < info->dlpi_phnum; i++) { - if ((info->dlpi_phdr[i].p_type == PT_LOAD) && (info->dlpi_phdr[i].p_flags == PF_X)) { - mprotect(reinterpret_cast(info->dlpi_addr + info->dlpi_phdr[i].p_vaddr), - info->dlpi_phdr[i].p_memsz, PROT_READ | PROT_EXEC); + const auto& phdr = info->dlpi_phdr[i]; + if ((phdr.p_type == PT_LOAD) && (phdr.p_flags == PF_X)) { + auto addr = reinterpret_cast(info->dlpi_addr + PAGE_START(phdr.p_vaddr)); + size_t len = PAGE_OFFSET(phdr.p_vaddr) + phdr.p_memsz; + if (mprotect(addr, len, PROT_READ | PROT_EXEC) == -1) { + ALOGE("mprotect(%p, %zu, PROT_READ | PROT_EXEC) failed: %m", addr, len); + return -1; + } } } // Return non-zero to exit dl_iterate_phdr.