From 9d65e0def5d435c7adf837444141917f0fa5f92b Mon Sep 17 00:00:00 2001 From: Siarhei Vishniakou Date: Fri, 1 Sep 2017 20:59:21 -0700 Subject: [PATCH] Clarify that getLocalState is always valid for DragEvent The method getLocalState() always returns valid data (if the data was stored in startDragAndDrop to begin with), but the documentation currently states that the events with action ACTION_DRAG_ENDED do not have valid local state. Bug: 62067188 Test: bit CtsViewTestCases:android.view.cts.DragDropTest Change-Id: Ia2f8e5e0bb068aa7ac4aac3f18a5cf01d1a73c32 --- core/java/android/view/DragEvent.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/java/android/view/DragEvent.java b/core/java/android/view/DragEvent.java index 16f2d7d0b6c7e..2c9f87128bca3 100644 --- a/core/java/android/view/DragEvent.java +++ b/core/java/android/view/DragEvent.java @@ -103,7 +103,7 @@ import com.android.internal.view.IDragAndDropPermissions; * * ACTION_DRAG_ENDED *   - *   + * X *   *   *   @@ -112,6 +112,7 @@ import com.android.internal.view.IDragAndDropPermissions; * *

* The {@link android.view.DragEvent#getAction()}, + * {@link android.view.DragEvent#getLocalState()} * {@link android.view.DragEvent#describeContents()}, * {@link android.view.DragEvent#writeToParcel(Parcel,int)}, and * {@link android.view.DragEvent#toString()} methods always return valid data. @@ -397,7 +398,7 @@ public class DragEvent implements Parcelable { * operation. In all other activities this method will return null *

*

- * This method returns valid data for all event actions except for {@link #ACTION_DRAG_ENDED}. + * This method returns valid data for all event actions. *

* @return The local state object sent to the system by startDragAndDrop(). */