Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Remove obsolete/infeasible TODOs" into rvc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-04-07 00:12:09 +00:00
committed by Android (Google) Code Review
parent 51a5c0c3e5 1d4fdcb6de
commit d5729ebc66
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmds/statsd/src/logd/LogEvent.h
View File

@@ -218,9 +218,6 @@ private:
* The below three variables are only valid during the execution of * The below three variables are only valid during the execution of
* parseBuffer. There are no guarantees about the state of these variables * parseBuffer. There are no guarantees about the state of these variables
* before/after. * before/after.
*
* TODO (b/150312423): These shouldn't be member variables. We should pass
* them around as parameters.
*/ */
uint8_t* mBuf; uint8_t* mBuf;
uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed

1
cmds/statsd/src/shell/ShellSubscriber.cpp
View File

@@ -152,7 +152,6 @@ void ShellSubscriber::startPull(int64_t myToken) {
mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data); mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data);
VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id()); VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id());
// TODO(b/150969574): Don't write to a pipe while holding a lock.
if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) { if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) {
mSubscriptionInfo->mClientAlive = false; mSubscriptionInfo->mClientAlive = false;
mSubscriptionShouldEnd.notify_one(); mSubscriptionShouldEnd.notify_one();