Merge "Remove obsolete/infeasible TODOs" into rvc-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
d5729ebc66
@@ -218,9 +218,6 @@ private:
|
||||
* The below three variables are only valid during the execution of
|
||||
* parseBuffer. There are no guarantees about the state of these variables
|
||||
* before/after.
|
||||
*
|
||||
* TODO (b/150312423): These shouldn't be member variables. We should pass
|
||||
* them around as parameters.
|
||||
*/
|
||||
uint8_t* mBuf;
|
||||
uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed
|
||||
|
||||
@@ -152,7 +152,6 @@ void ShellSubscriber::startPull(int64_t myToken) {
|
||||
mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data);
|
||||
VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id());
|
||||
|
||||
// TODO(b/150969574): Don't write to a pipe while holding a lock.
|
||||
if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) {
|
||||
mSubscriptionInfo->mClientAlive = false;
|
||||
mSubscriptionShouldEnd.notify_one();
|
||||
|
||||
Reference in New Issue
Block a user