Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Don't require unlock to dismiss a media control" into sc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2021-05-27 12:24:20 +00:00
committed by Android (Google) Code Review
parent 14016d39a6 acc34e6c57
commit d565aaa1ff
2 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/SystemUI/src/com/android/systemui/media/MediaControlPanel.java
View File

@@ -447,11 +447,8 @@ public class MediaControlPanel {
if (mKey != null) { if (mKey != null) {
closeGuts(); closeGuts();
mKeyguardDismissUtil.executeWhenUnlocked(() -> {
mMediaDataManagerLazy.get().dismissMediaData(mKey, mMediaDataManagerLazy.get().dismissMediaData(mKey,
MediaViewController.GUTS_ANIMATION_DURATION + 100); MediaViewController.GUTS_ANIMATION_DURATION + 100);
return true;
}, /* requiresShadeOpen */ true, false);
} else { } else {
Log.w(TAG, "Dismiss media with null notification. Token uid=" Log.w(TAG, "Dismiss media with null notification. Token uid="
+ data.getToken().getUid()); + data.getToken().getUid());
@@ -576,11 +573,8 @@ public class MediaControlPanel {
logSmartspaceCardReported(761, // SMARTSPACE_CARD_DISMISS logSmartspaceCardReported(761, // SMARTSPACE_CARD_DISMISS
/* isRecommendationCard */ true); /* isRecommendationCard */ true);
closeGuts(); closeGuts();
mKeyguardDismissUtil.executeWhenUnlocked(() -> {
mMediaDataManagerLazy.get().dismissSmartspaceRecommendation( mMediaDataManagerLazy.get().dismissSmartspaceRecommendation(
MediaViewController.GUTS_ANIMATION_DURATION + 100L); MediaViewController.GUTS_ANIMATION_DURATION + 100L);
return true;
}, true /* requiresShadeOpen */, false);
}); });
mController = null; mController = null;

6
packages/SystemUI/tests/src/com/android/systemui/media/MediaControlPanelTest.kt
View File

@@ -55,7 +55,6 @@ import org.junit.runner.RunWith
import org.mockito.ArgumentCaptor import org.mockito.ArgumentCaptor
import org.mockito.ArgumentMatchers.anyLong import org.mockito.ArgumentMatchers.anyLong
import org.mockito.Mock import org.mockito.Mock
import org.mockito.Mockito.anyBoolean
import org.mockito.Mockito.mock import org.mockito.Mockito.mock
import org.mockito.Mockito.never import org.mockito.Mockito.never
import org.mockito.Mockito.verify import org.mockito.Mockito.verify
@@ -329,11 +328,6 @@ public class MediaControlPanelTest : SysuiTestCase() {
assertThat(dismiss.isEnabled).isEqualTo(true) assertThat(dismiss.isEnabled).isEqualTo(true)
dismiss.callOnClick() dismiss.callOnClick()
val captor = ArgumentCaptor.forClass(ActivityStarter.OnDismissAction::class.java)
verify(keyguardDismissUtil).executeWhenUnlocked(captor.capture(), anyBoolean(),
eq(false))
captor.value.onDismiss()
verify(mediaDataManager).dismissMediaData(eq(mediaKey), anyLong()) verify(mediaDataManager).dismissMediaData(eq(mediaKey), anyLong())
} }