From 33d6c08aa605bda7141ae987af0b6a8eb9329161 Mon Sep 17 00:00:00 2001 From: Michael Wright Date: Fri, 21 Jul 2017 16:40:58 +0100 Subject: [PATCH] Remove non-safe mode boot vibration. Ding, dong the BZZZT is dead. Bug: 22414771 Test: manual Change-Id: I011a9b475a6497db6e9440647d6d5c60dcf171b7 --- .../java/android/view/HapticFeedbackConstants.java | 7 +------ core/res/res/values/config.xml | 10 +--------- core/res/res/values/symbols.xml | 1 - .../policy/AccessibilityShortcutController.java | 2 +- .../android/server/policy/PhoneWindowManager.java | 14 +++----------- 5 files changed, 6 insertions(+), 28 deletions(-) diff --git a/core/java/android/view/HapticFeedbackConstants.java b/core/java/android/view/HapticFeedbackConstants.java index 71a3f7e2817e5..c43132388b565 100644 --- a/core/java/android/view/HapticFeedbackConstants.java +++ b/core/java/android/view/HapticFeedbackConstants.java @@ -69,12 +69,7 @@ public class HapticFeedbackConstants { public static final int TEXT_HANDLE_MOVE = 8; /** - * This is a private constant. Feel free to renumber as desired. - * @hide - */ - public static final int SAFE_MODE_DISABLED = 10000; - - /** + * The phone has booted with safe mode enabled. * This is a private constant. Feel free to renumber as desired. * @hide */ diff --git a/core/res/res/values/config.xml b/core/res/res/values/config.xml index f817ab39bf6c1..f56abc3e13bd3 100644 --- a/core/res/res/values/config.xml +++ b/core/res/res/values/config.xml @@ -959,15 +959,7 @@ 30 - - - 0 - 1 - 20 - 21 - - - + 0 1 diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 7670c7ba4086b..baa73862db698 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -1557,7 +1557,6 @@ - diff --git a/services/core/java/com/android/server/policy/AccessibilityShortcutController.java b/services/core/java/com/android/server/policy/AccessibilityShortcutController.java index 50900834b16a4..0b54e5e53822c 100644 --- a/services/core/java/com/android/server/policy/AccessibilityShortcutController.java +++ b/services/core/java/com/android/server/policy/AccessibilityShortcutController.java @@ -154,7 +154,7 @@ public class AccessibilityShortcutController { // Don't check if haptics are disabled, as we need to alert the user that their // way of interacting with the phone may change if they activate the shortcut long[] vibePattern = PhoneWindowManager.getLongIntArray(mContext.getResources(), - R.array.config_safeModeDisabledVibePattern); + R.array.config_longPressVibePattern); vibrator.vibrate(vibePattern, -1, VIBRATION_ATTRIBUTES); } diff --git a/services/core/java/com/android/server/policy/PhoneWindowManager.java b/services/core/java/com/android/server/policy/PhoneWindowManager.java index 8e2097ae26096..8a39df2435188 100644 --- a/services/core/java/com/android/server/policy/PhoneWindowManager.java +++ b/services/core/java/com/android/server/policy/PhoneWindowManager.java @@ -431,9 +431,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { // Vibrator pattern for a short vibration when tapping on a day/month/year date of a Calendar. long[] mCalendarDateVibePattern; - // Vibrator pattern for haptic feedback during boot when safe mode is disabled. - long[] mSafeModeDisabledVibePattern; - // Vibrator pattern for haptic feedback during boot when safe mode is enabled. long[] mSafeModeEnabledVibePattern; @@ -2076,8 +2073,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { com.android.internal.R.array.config_longPressVibePattern); mCalendarDateVibePattern = getLongIntArray(mContext.getResources(), com.android.internal.R.array.config_calendarDateVibePattern); - mSafeModeDisabledVibePattern = getLongIntArray(mContext.getResources(), - com.android.internal.R.array.config_safeModeDisabledVibePattern); mSafeModeEnabledVibePattern = getLongIntArray(mContext.getResources(), com.android.internal.R.array.config_safeModeEnabledVibePattern); @@ -7226,9 +7221,9 @@ public class PhoneWindowManager implements WindowManagerPolicy { @Override public void setSafeMode(boolean safeMode) { mSafeMode = safeMode; - performHapticFeedbackLw(null, safeMode - ? HapticFeedbackConstants.SAFE_MODE_ENABLED - : HapticFeedbackConstants.SAFE_MODE_DISABLED, true); + if (safeMode) { + performHapticFeedbackLw(null, HapticFeedbackConstants.SAFE_MODE_ENABLED, true); + } } static long[] getLongIntArray(Resources r, int resid) { @@ -7747,9 +7742,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { case HapticFeedbackConstants.CALENDAR_DATE: pattern = mCalendarDateVibePattern; break; - case HapticFeedbackConstants.SAFE_MODE_DISABLED: - pattern = mSafeModeDisabledVibePattern; - break; case HapticFeedbackConstants.SAFE_MODE_ENABLED: pattern = mSafeModeEnabledVibePattern; break;