diff --git a/libs/hwui/tests/unit/FatalTestCanvas.h b/libs/hwui/tests/unit/FatalTestCanvas.h index b4132b7b44ed2..4831722b93e68 100644 --- a/libs/hwui/tests/unit/FatalTestCanvas.h +++ b/libs/hwui/tests/unit/FatalTestCanvas.h @@ -121,13 +121,13 @@ public: const SkPaint*) { ADD_FAILURE() << "onDrawBitmapLattice not expected in this test"; } - void onClipRRect(const SkRRect& rrect, ClipOp, ClipEdgeStyle) { + void onClipRRect(const SkRRect& rrect, SkClipOp, ClipEdgeStyle) { ADD_FAILURE() << "onClipRRect not expected in this test"; } - void onClipPath(const SkPath& path, ClipOp, ClipEdgeStyle) { + void onClipPath(const SkPath& path, SkClipOp, ClipEdgeStyle) { ADD_FAILURE() << "onClipPath not expected in this test"; } - void onClipRegion(const SkRegion& deviceRgn, ClipOp) { + void onClipRegion(const SkRegion& deviceRgn, SkClipOp) { ADD_FAILURE() << "onClipRegion not expected in this test"; } void onDiscard() { diff --git a/libs/hwui/tests/unit/SkiaPipelineTests.cpp b/libs/hwui/tests/unit/SkiaPipelineTests.cpp index 9b5fa307ebf71..06f86930fcf88 100644 --- a/libs/hwui/tests/unit/SkiaPipelineTests.cpp +++ b/libs/hwui/tests/unit/SkiaPipelineTests.cpp @@ -206,7 +206,6 @@ public: , mCanvas(canvas) { } SkCanvas* onNewCanvas() override { - mCanvas->ref(); return mCanvas; } sk_sp onNewSurface(const SkImageInfo&) override { @@ -216,7 +215,7 @@ public: return sk_sp(); } void onCopyOnWrite(ContentChangeMode) override {} - T* mCanvas; + T* mCanvas; // bare pointer, not owned/ref'd }; } @@ -281,10 +280,10 @@ RENDERTHREAD_TEST(SkiaPipeline, deferRenderNodeScene) { LayerUpdateQueue layerUpdateQueue; SkRect dirty = SkRect::MakeWH(800, 600); auto pipeline = std::make_unique(renderThread); - sk_sp canvas(new DeferTestCanvas()); - sk_sp surface(new DeferLayer(canvas.get())); + DeferTestCanvas canvas; + sk_sp surface(new DeferLayer(&canvas)); pipeline->renderFrame(layerUpdateQueue, dirty, nodes, true, contentDrawBounds, surface); - EXPECT_EQ(4, canvas->mDrawCounter); + EXPECT_EQ(4, canvas.mDrawCounter); } RENDERTHREAD_TEST(SkiaPipeline, clipped) { @@ -312,11 +311,11 @@ RENDERTHREAD_TEST(SkiaPipeline, clipped) { LayerUpdateQueue layerUpdateQueue; SkRect dirty = SkRect::MakeLTRB(10, 20, 30, 40); auto pipeline = std::make_unique(renderThread); - sk_sp canvas(new ClippedTestCanvas()); - sk_sp surface(new DeferLayer(canvas.get())); + ClippedTestCanvas canvas; + sk_sp surface(new DeferLayer(&canvas)); pipeline->renderFrame(layerUpdateQueue, dirty, nodes, true, SkRect::MakeWH(CANVAS_WIDTH, CANVAS_HEIGHT), surface); - EXPECT_EQ(1, canvas->mDrawCounter); + EXPECT_EQ(1, canvas.mDrawCounter); } RENDERTHREAD_TEST(SkiaPipeline, clip_replace) { @@ -347,9 +346,9 @@ RENDERTHREAD_TEST(SkiaPipeline, clip_replace) { LayerUpdateQueue layerUpdateQueue; SkRect dirty = SkRect::MakeLTRB(10, 10, 40, 40); auto pipeline = std::make_unique(renderThread); - sk_sp canvas(new ClipReplaceTestCanvas()); - sk_sp surface(new DeferLayer(canvas.get())); + ClipReplaceTestCanvas canvas; + sk_sp surface(new DeferLayer(&canvas)); pipeline->renderFrame(layerUpdateQueue, dirty, nodes, true, SkRect::MakeWH(CANVAS_WIDTH, CANVAS_HEIGHT), surface); - EXPECT_EQ(1, canvas->mDrawCounter); + EXPECT_EQ(1, canvas.mDrawCounter); } diff --git a/libs/hwui/tests/unit/SkiaRenderPropertiesTests.cpp b/libs/hwui/tests/unit/SkiaRenderPropertiesTests.cpp index ec2efc8d88b66..e7171c8d44abe 100644 --- a/libs/hwui/tests/unit/SkiaRenderPropertiesTests.cpp +++ b/libs/hwui/tests/unit/SkiaRenderPropertiesTests.cpp @@ -51,7 +51,7 @@ static void testProperty(std::function propSetupCallbac EXPECT_EQ(mDrawCounter++, 0); mCallback(*this); } - void onClipRRect(const SkRRect& rrect, ClipOp op, ClipEdgeStyle style) { + void onClipRRect(const SkRRect& rrect, SkClipOp op, ClipEdgeStyle style) { SkCanvas::onClipRRect(rrect, op, style); } std::function mCallback; @@ -65,10 +65,10 @@ static void testProperty(std::function propSetupCallbac canvas.drawRect(0, 0, CANVAS_WIDTH, CANVAS_HEIGHT, paint); }); - sk_sp canvas(new PropertyTestCanvas(opValidateCallback)); - RenderNodeDrawable drawable(node.get(), canvas.get(), true); - canvas->drawDrawable(&drawable); - EXPECT_EQ(1, canvas->mDrawCounter); + PropertyTestCanvas canvas(opValidateCallback); + RenderNodeDrawable drawable(node.get(), &canvas, true); + canvas.drawDrawable(&drawable); + EXPECT_EQ(1, canvas.mDrawCounter); } }