From 907f3e3e9b5dd08bb928e7da860ac053d7005a49 Mon Sep 17 00:00:00 2001 From: Winson Chiu Date: Fri, 9 Oct 2020 17:42:23 +0000 Subject: [PATCH] Deprecate PackageParser main class and add OWNERS This wasn't deprecated in the original refactor because there was no publicly exposed alternative that encapsulated all the functionality. There are also some subclasses which are still used as they haven't been copied to the parsing subpackage yet. But this has lead to contributors making changes to PackageParser, not realizing that the class is unused. So it's worth marking it deprecated just so it's obvious to anyone editing the code. The changes made since last release seem mostly unconsequential, so they will not be reverted, but no additional new code should be added. Also protects PackageParser and core parsing with OWNERS. Test: none, docs change Change-Id: I9d80132503b3a5a3384abbe6b0b1fbb752029710 --- core/java/android/content/pm/OWNERS | 1 + core/java/android/content/pm/PackageParser.java | 6 ++++++ core/java/android/content/pm/parsing/OWNERS | 5 +++++ 3 files changed, 12 insertions(+) create mode 100644 core/java/android/content/pm/OWNERS create mode 100644 core/java/android/content/pm/parsing/OWNERS diff --git a/core/java/android/content/pm/OWNERS b/core/java/android/content/pm/OWNERS new file mode 100644 index 0000000000000..a16bb4ff3b1d7 --- /dev/null +++ b/core/java/android/content/pm/OWNERS @@ -0,0 +1 @@ +per-file PackageParser.java = chiuwinson@google.com diff --git a/core/java/android/content/pm/PackageParser.java b/core/java/android/content/pm/PackageParser.java index 0adb66c72065e..a30a6525fab52 100644 --- a/core/java/android/content/pm/PackageParser.java +++ b/core/java/android/content/pm/PackageParser.java @@ -143,8 +143,14 @@ import java.util.UUID; *
  • All installations must contain a single base APK. * * + * @deprecated This class is mostly unused and no new changes should be added to it. Use + * {@link android.content.pm.parsing.ParsingPackageUtils} and related parsing v2 infrastructure in + * the core/services parsing subpackages. Or for a quick parse of a provided APK, use + * {@link PackageManager#getPackageArchiveInfo(String, int)}. + * * @hide */ +@Deprecated public class PackageParser { public static final boolean DEBUG_JAR = false; diff --git a/core/java/android/content/pm/parsing/OWNERS b/core/java/android/content/pm/parsing/OWNERS new file mode 100644 index 0000000000000..8049d5cb7fa28 --- /dev/null +++ b/core/java/android/content/pm/parsing/OWNERS @@ -0,0 +1,5 @@ +# Bug component: 36137 + +chiuwinson@google.com +patb@google.com +toddke@google.com