From d3a795d9dd0136dd21ca9965983a2f766d349672 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20Kurucz?= Date: Thu, 5 Jan 2023 15:14:15 +0000 Subject: [PATCH] Enhance BubbleController dumps - Fix a formatting issue - Dump Bubble$mIsClearable in BubblesController Sometimes when dismissing a Notification which has a Bubble, it gets stuck in the Shade. A possible reason is that we restore the wrong value for this field (false), which blocks us from dismissing it. Bug: 237897866 Test: adb shell dumpsys activity service com.android.systemui/.SystemUIService WMShell Change-Id: I38fc1355b4706cab3cf87f415e97f569e2e2ba50 --- .../Shell/src/com/android/wm/shell/bubbles/Bubble.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/Bubble.java b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/Bubble.java index 922472a261132..09dc68a4cceaa 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/Bubble.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/Bubble.java @@ -870,7 +870,8 @@ public class Bubble implements BubbleViewProvider { pw.print(" desiredHeight: "); pw.println(getDesiredHeightString()); pw.print(" suppressNotif: "); pw.println(shouldSuppressNotification()); pw.print(" autoExpand: "); pw.println(shouldAutoExpand()); - pw.print(" bubbleMetadataFlagListener null: " + (mBubbleMetadataFlagListener == null)); + pw.print(" isClearable: "); pw.println(mIsClearable); + pw.println(" bubbleMetadataFlagListener null: " + (mBubbleMetadataFlagListener == null)); if (mExpandedView != null) { mExpandedView.dump(pw); }