From d395f7913336417bcbbea740fcdc8589789626bc Mon Sep 17 00:00:00 2001 From: Dan Albert Date: Mon, 20 Oct 2014 14:44:39 -0700 Subject: [PATCH] Fix an overflow found by ASAN. Sometimes len is 0. Change-Id: I031000188edc57663a5519b00cbbb751600d32f4 --- tools/aapt/Resource.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/aapt/Resource.cpp b/tools/aapt/Resource.cpp index 6ebf41f1ad96a..cc9207dc39e0f 100644 --- a/tools/aapt/Resource.cpp +++ b/tools/aapt/Resource.cpp @@ -553,7 +553,7 @@ static int validateAttr(const String8& path, const ResTable& table, String8(parser.getElementName(&len)).string(), attr); return ATTR_LEADING_SPACES; } - if (str[len-1] == ' ') { + if (len != 0 && str[len-1] == ' ') { fprintf(stderr, "%s:%d: Tag <%s> attribute %s can not end with a space.\n", path.string(), parser.getLineNumber(), String8(parser.getElementName(&len)).string(), attr);