Merge "Remove temporary double icon workarounds" into udc-dev

This commit is contained in:
Massimo Carli
2023-05-09 16:43:57 +00:00
committed by Android (Google) Code Review
3 changed files with 2 additions and 19 deletions

View File

@@ -21,7 +21,6 @@ import android.app.TaskInfo;
import android.app.TaskInfo.CameraCompatControlState; import android.app.TaskInfo.CameraCompatControlState;
import android.content.Context; import android.content.Context;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.view.MotionEvent;
import android.view.View; import android.view.View;
import android.widget.ImageButton; import android.widget.ImageButton;
import android.widget.LinearLayout; import android.widget.LinearLayout;
@@ -112,14 +111,6 @@ class CompatUILayout extends LinearLayout {
mWindowManager.relayout(); mWindowManager.relayout();
} }
@Override
public boolean onInterceptTouchEvent(MotionEvent ev) {
if (ev.getAction() == MotionEvent.ACTION_DOWN) {
mWindowManager.relayout();
}
return super.onInterceptTouchEvent(ev);
}
@Override @Override
protected void onFinishInflate() { protected void onFinishInflate() {
super.onFinishInflate(); super.onFinishInflate();

View File

@@ -204,14 +204,7 @@ class CompatUIWindowManager extends CompatUIWindowManagerAbstract {
: taskStableBounds.right - taskBounds.left - mLayout.getMeasuredWidth(); : taskStableBounds.right - taskBounds.left - mLayout.getMeasuredWidth();
final int positionY = taskStableBounds.bottom - taskBounds.top final int positionY = taskStableBounds.bottom - taskBounds.top
- mLayout.getMeasuredHeight(); - mLayout.getMeasuredHeight();
// To secure a proper visualisation, we hide the layout while updating the position of
// the {@link SurfaceControl} it belongs.
final int oldVisibility = mLayout.getVisibility();
if (oldVisibility == View.VISIBLE) {
mLayout.setVisibility(View.GONE);
}
updateSurfacePosition(positionX, positionY); updateSurfacePosition(positionX, positionY);
mLayout.setVisibility(oldVisibility);
} }
private void updateVisibilityOfViews() { private void updateVisibilityOfViews() {

View File

@@ -28,7 +28,6 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.anyBoolean; import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.clearInvocations; import static org.mockito.Mockito.clearInvocations;
import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
@@ -363,14 +362,14 @@ public class CompatUIWindowManagerTest extends ShellTestCase {
mWindowManager.updateVisibility(/* canShow= */ false); mWindowManager.updateVisibility(/* canShow= */ false);
verify(mWindowManager, never()).createLayout(anyBoolean()); verify(mWindowManager, never()).createLayout(anyBoolean());
verify(mLayout, atLeastOnce()).setVisibility(View.GONE); verify(mLayout).setVisibility(View.GONE);
// Show button. // Show button.
doReturn(View.GONE).when(mLayout).getVisibility(); doReturn(View.GONE).when(mLayout).getVisibility();
mWindowManager.updateVisibility(/* canShow= */ true); mWindowManager.updateVisibility(/* canShow= */ true);
verify(mWindowManager, never()).createLayout(anyBoolean()); verify(mWindowManager, never()).createLayout(anyBoolean());
verify(mLayout, atLeastOnce()).setVisibility(View.VISIBLE); verify(mLayout).setVisibility(View.VISIBLE);
} }
@Test @Test