From ed16d4b7deb767f10db80ba57fca3721ac814c92 Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Thu, 24 Sep 2009 15:04:01 -0700 Subject: [PATCH] Fix bug#2144742: guard against 0 length encoded string when attaching a 'from' address for MMS. Change-Id: I0aad5b3d2834695b44cbb63e40c43a2159b723d9 --- core/java/com/google/android/mms/pdu/PduComposer.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/java/com/google/android/mms/pdu/PduComposer.java b/core/java/com/google/android/mms/pdu/PduComposer.java index 8b31936f609e5..2aa5e48f507ee 100644 --- a/core/java/com/google/android/mms/pdu/PduComposer.java +++ b/core/java/com/google/android/mms/pdu/PduComposer.java @@ -19,6 +19,8 @@ package com.google.android.mms.pdu; import android.content.ContentResolver; import android.content.Context; +import android.util.Log; +import android.text.TextUtils; import java.io.ByteArrayOutputStream; import java.io.FileNotFoundException; @@ -528,6 +530,7 @@ public class PduComposer { EncodedStringValue from = mPduHeader.getEncodedStringValue(field); if ((from == null) + || TextUtils.isEmpty(from.getString()) || new String(from.getTextString()).equals( PduHeaders.FROM_INSERT_ADDRESS_TOKEN_STR)) { // Length of from = 1