From d25ec877da0538406464101ea73139c84cde7794 Mon Sep 17 00:00:00 2001 From: "Philip P. Moltmann" Date: Thu, 2 Aug 2018 12:12:55 -0700 Subject: [PATCH] Make package installer a sequence of alert-dialogs. To make sure the dialog does not change height a single content for all steps of the sequence. We just unhide the view that should actually be shown. Also added a night-mode theme. Test: Manually uninstalled, installed and update package. atest CtsNoPermissionTestCases CtsNoPermissionTestCases25 CtsPackageInstallTestCases CtsPackageUninstallTestCases CtsPackageInstallerTapjackingTestCases Change-Id: I890bb1f2697df3af87b6cb65e460f611334523ee --- packages/PackageInstaller/AndroidManifest.xml | 14 +- .../res/layout/install_confirm.xml | 91 ----------- .../res/layout/install_content_view.xml | 144 ++++++++++++++++++ .../res/layout/install_failed.xml | 96 ------------ .../res/layout/install_installing.xml | 108 ------------- .../res/layout/install_staging.xml | 113 -------------- .../res/layout/install_success.xml | 101 ------------ .../res/values-night/themes.xml | 23 +++ .../PackageInstaller/res/values/strings.xml | 4 +- .../PackageInstaller/res/values/styles.xml | 39 ----- .../PackageInstaller/res/values/themes.xml | 20 +-- .../packageinstaller/InstallFailed.java | 45 +++--- .../packageinstaller/InstallInstalling.java | 52 ++++--- .../packageinstaller/InstallStaging.java | 27 ++-- .../packageinstaller/InstallSuccess.java | 34 +++-- .../OverlayTouchActivity.java | 29 ---- .../PackageInstallerActivity.java | 80 +++++----- .../android/packageinstaller/PackageUtil.java | 20 --- 18 files changed, 310 insertions(+), 730 deletions(-) delete mode 100644 packages/PackageInstaller/res/layout/install_confirm.xml create mode 100644 packages/PackageInstaller/res/layout/install_content_view.xml delete mode 100644 packages/PackageInstaller/res/layout/install_failed.xml delete mode 100644 packages/PackageInstaller/res/layout/install_installing.xml delete mode 100644 packages/PackageInstaller/res/layout/install_staging.xml delete mode 100644 packages/PackageInstaller/res/layout/install_success.xml create mode 100644 packages/PackageInstaller/res/values-night/themes.xml delete mode 100755 packages/PackageInstaller/res/values/styles.xml delete mode 100644 packages/PackageInstaller/src/com/android/packageinstaller/OverlayTouchActivity.java diff --git a/packages/PackageInstaller/AndroidManifest.xml b/packages/PackageInstaller/AndroidManifest.xml index 513c8624ca71b..2be9311d91ead 100644 --- a/packages/PackageInstaller/AndroidManifest.xml +++ b/packages/PackageInstaller/AndroidManifest.xml @@ -19,7 +19,7 @@ android:label="@string/app_name" android:icon="@drawable/ic_app_icon" android:allowBackup="false" - android:theme="@style/DialogWhenLarge" + android:theme="@style/Theme.AlertDialogActivity" android:supportsRtl="true" android:defaultToDeviceProtectedStorage="true" android:directBootAware="true"> @@ -32,6 +32,7 @@ @@ -59,13 +60,14 @@ android:exported="false" /> + android:noHistory="true"> @@ -107,7 +108,6 @@ - - - - - - - - - - - - - - - - - - - - - - - -