From 0bb9960598067f3320cdae8ab42c1ba0f3376f21 Mon Sep 17 00:00:00 2001 From: Tammo Spalink Date: Tue, 8 Sep 2009 18:30:33 +0800 Subject: [PATCH] Do not die when printing empty prefs. Addresses issue: http://buganizer/issue?id=1974140 Change-Id: I0001d69e8d278d4ca900f5ce56ad50c0b4b6b694 --- core/java/android/preference/Preference.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/java/android/preference/Preference.java b/core/java/android/preference/Preference.java index fc395732f47e1..08a2a9f37aaa4 100644 --- a/core/java/android/preference/Preference.java +++ b/core/java/android/preference/Preference.java @@ -1456,8 +1456,10 @@ public class Preference implements Comparable, OnDependencyChangeLis if (!TextUtils.isEmpty(summary)) { sb.append(summary).append(' '); } - // Drop the last space - sb.setLength(sb.length() - 1); + if (sb.length() > 0) { + // Drop the last space + sb.setLength(sb.length() - 1); + } return sb; }