From 5e43f2dd087ed4a7389d75299d5c7463f4af7c9e Mon Sep 17 00:00:00 2001 From: Evan Laird Date: Thu, 13 Jul 2017 11:09:39 -0400 Subject: [PATCH] Fix mobile signal colors to match wifi et al Test: visual; Change-Id: Ic810d10d86ea5878e8a025b0d48c9ca7496ea819 Fixes: 63391344 --- .../src/com/android/systemui/qs/CellTileView.java | 12 ++++++------ .../systemui/statusbar/phone/SignalDrawable.java | 5 +++++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/CellTileView.java b/packages/SystemUI/src/com/android/systemui/qs/CellTileView.java index 5b3ec08ce7526..3d8f9ffe79d77 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/CellTileView.java +++ b/packages/SystemUI/src/com/android/systemui/qs/CellTileView.java @@ -16,12 +16,14 @@ package com.android.systemui.qs; import android.content.Context; import android.graphics.drawable.Drawable; +import android.service.quicksettings.Tile; import android.widget.ImageView; import com.android.settingslib.Utils; import com.android.systemui.R; import com.android.systemui.plugins.qs.QSTile.Icon; import com.android.systemui.plugins.qs.QSTile.State; +import com.android.systemui.qs.tileimpl.QSTileImpl; import com.android.systemui.statusbar.phone.SignalDrawable; import java.util.Objects; @@ -35,7 +37,8 @@ public class CellTileView extends SignalTileView { public CellTileView(Context context) { super(context); mSignalDrawable = new SignalDrawable(mContext); - mSignalDrawable.setDarkIntensity(isDark(mContext)); + mSignalDrawable.setColors(QSTileImpl.getColorForState(context, Tile.STATE_UNAVAILABLE), + QSTileImpl.getColorForState(context, Tile.STATE_ACTIVE)); mSignalDrawable.setIntrinsicSize(context.getResources().getDimensionPixelSize( R.dimen.qs_tile_icon_size)); } @@ -48,10 +51,6 @@ public class CellTileView extends SignalTileView { } } - private static int isDark(Context context) { - return Utils.getColorAttr(context, android.R.attr.colorForeground) == 0xff000000 ? 1 : 0; - } - public static class SignalIcon extends Icon { private final int mState; @@ -68,7 +67,8 @@ public class CellTileView extends SignalTileView { public Drawable getDrawable(Context context) { //TODO: Not the optimal solution to create this drawable SignalDrawable d = new SignalDrawable(context); - d.setDarkIntensity(isDark(context)); + d.setColors(QSTileImpl.getColorForState(context, Tile.STATE_UNAVAILABLE), + QSTileImpl.getColorForState(context, Tile.STATE_ACTIVE)); d.setLevel(getState()); return d; } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/SignalDrawable.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/SignalDrawable.java index d537cda00b103..a1f6f31c4b026 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/SignalDrawable.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/SignalDrawable.java @@ -198,6 +198,11 @@ public class SignalDrawable extends Drawable { return true; } + public void setColors(int background, int foreground) { + mPaint.setColor(background); + mForegroundPaint.setColor(foreground); + } + public void setDarkIntensity(float darkIntensity) { if (darkIntensity == mOldDarkIntensity) { return;