From 4f3ebc43af1f254d99e1cf64620ff94d28023bd2 Mon Sep 17 00:00:00 2001 From: Jaikumar Ganesh Date: Wed, 16 Sep 2009 15:15:21 -0700 Subject: [PATCH] Fix async calls with Connect And Disconnect Sink. Change-Id: I814c7fdf40ec0d6aefeb410b1a1b1572ab4a8d88 --- .../android_server_BluetoothA2dpService.cpp | 40 +++++-------------- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/core/jni/android_server_BluetoothA2dpService.cpp b/core/jni/android_server_BluetoothA2dpService.cpp index a185d8d30f2d7..ba13519873fd0 100644 --- a/core/jni/android_server_BluetoothA2dpService.cpp +++ b/core/jni/android_server_BluetoothA2dpService.cpp @@ -133,23 +133,13 @@ static jboolean connectSinkNative(JNIEnv *env, jobject object, jstring path) { LOGV(__FUNCTION__); if (nat) { const char *c_path = env->GetStringUTFChars(path, NULL); - DBusError err; - dbus_error_init(&err); - DBusMessage *reply = - dbus_func_args_timeout(env, nat->conn, -1, c_path, - "org.bluez.AudioSink", "Connect", - DBUS_TYPE_INVALID); + bool ret = dbus_func_args_async(env, nat->conn, -1, NULL, NULL, nat, + c_path, "org.bluez.AudioSink", "Connect", + DBUS_TYPE_INVALID); + env->ReleaseStringUTFChars(path, c_path); - - if (!reply && dbus_error_is_set(&err)) { - LOG_AND_FREE_DBUS_ERROR_WITH_MSG(&err, reply); - return JNI_FALSE; - } else if (!reply) { - LOGE("DBus reply is NULL in function %s", __FUNCTION__); - return JNI_FALSE; - } - return JNI_TRUE; + return ret ? JNI_TRUE : JNI_FALSE; } #endif return JNI_FALSE; @@ -161,23 +151,13 @@ static jboolean disconnectSinkNative(JNIEnv *env, jobject object, LOGV(__FUNCTION__); if (nat) { const char *c_path = env->GetStringUTFChars(path, NULL); - DBusError err; - dbus_error_init(&err); - DBusMessage *reply = - dbus_func_args_timeout(env, nat->conn, -1, c_path, - "org.bluez.AudioSink", "Disconnect", - DBUS_TYPE_INVALID); + bool ret = dbus_func_args_async(env, nat->conn, -1, NULL, NULL, nat, + c_path, "org.bluez.AudioSink", "Disconnect", + DBUS_TYPE_INVALID); + env->ReleaseStringUTFChars(path, c_path); - - if (!reply && dbus_error_is_set(&err)) { - LOG_AND_FREE_DBUS_ERROR_WITH_MSG(&err, reply); - return JNI_FALSE; - } else if (!reply) { - LOGE("DBus reply is NULL in function %s", __FUNCTION__); - return JNI_FALSE; - } - return JNI_TRUE; + return ret ? JNI_TRUE : JNI_FALSE; } #endif return JNI_FALSE;