Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In setDefaultSelection ensure that webkit is notified of the new selection.

Browse Source 
Fix for http://b/issue?id=2254732
This commit is contained in:
Leon Scroggins
2009-12-02 10:12:57 -05:00
parent 9ed7dc10d2
commit cfc2915d92
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
core/java/android/webkit/WebTextView.java
View File

@@ -644,7 +644,22 @@ import java.util.ArrayList;
/* package */ void setDefaultSelection() {
Spannable text = (Spannable) getText();
int selection = mSingle ? text.length() : 0;
Selection. setSelection(text, selection, selection);
if (Selection.getSelectionStart(text) == selection
&& Selection.getSelectionEnd(text) == selection) {
// The selection of the UI copy is set correctly, but the
// WebTextView still needs to inform the webkit thread to set the
// selection. Normally that is done in onSelectionChanged, but
// onSelectionChanged will not be called because the UI copy is not
// changing. (This can happen when the WebTextView takes focus.
// That onSelectionChanged was blocked because the selection set
// when focusing is not necessarily the desirable selection for
// WebTextView.)
if (mWebView != null) {
mWebView.setSelection(selection, selection);
}
} else {
Selection.setSelection(text, selection, selection);
}
}
/**