From 45146493c6cbb3f39d92b41e5bc8742fb1e04ff6 Mon Sep 17 00:00:00 2001 From: Svetoslav Date: Thu, 25 Jun 2015 11:53:02 -0700 Subject: [PATCH] Add missing conditional in settings provider Change-Id: I717e8b87eccbedf1a1abead77e7856a2aa2405fa --- .../src/com/android/providers/settings/SettingsProvider.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java index 44b9d8b7b55ee..41043eb0f2df7 100644 --- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java +++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java @@ -905,7 +905,9 @@ public class SettingsProvider extends ContentProvider { private boolean mutateSystemSetting(String name, String value, int runAsUserId, int operation) { // Check for permissions first. - hasPermissionsToMutateSystemSettings(); + if (!hasPermissionsToMutateSystemSettings()) { + return false; + } // Verify whether this operation is allowed for the calling package. if (!isAppOpWriteSettingsAllowedForCallingPackage()) {