From cf50dcf50227413078fa1fab3d02ba30726b9130 Mon Sep 17 00:00:00 2001 From: Dmitry Dementyev Date: Thu, 17 Nov 2016 14:14:11 -0800 Subject: [PATCH] Correctly update database during account rename. Bug: https://b.corp.google.com/issues/32907996 Test: Verified with CTS tests. Change-Id: I3ef8890b9a68d17208a5681a39a0895feaff5fa1 --- .../android/server/accounts/AccountManagerService.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/accounts/AccountManagerService.java b/services/core/java/com/android/server/accounts/AccountManagerService.java index b5fecfb17aeb6..8fd1d2f163ff8 100644 --- a/services/core/java/com/android/server/accounts/AccountManagerService.java +++ b/services/core/java/com/android/server/accounts/AccountManagerService.java @@ -1881,7 +1881,13 @@ public class AccountManagerService final long accountId = accounts.accountsDb.findDeAccountId(accountToRename); if (accountId >= 0) { accounts.accountsDb.renameCeAccount(accountId, newName); - accounts.accountsDb.renameDeAccount(accountId, newName, accountToRename.name); + if (accounts.accountsDb.renameDeAccount( + accountId, newName, accountToRename.name)) { + accounts.accountsDb.setTransactionSuccessful(); + } else { + Log.e(TAG, "renameAccount failed"); + return null; + } } } finally { accounts.accountsDb.endTransaction();