From cf392d143ef35888df43907c399d42fb16fd196b Mon Sep 17 00:00:00 2001 From: Adam Powell Date: Thu, 25 Jun 2015 14:48:45 -0700 Subject: [PATCH] Improve docs for View#addChildrenForAccessibility Clarify the role of the list parameter and associated method documentation. Bug 22053511 Change-Id: Id0200bba8e60242caee2547bce30764dcabe02fd --- core/java/android/view/View.java | 12 ++++++------ core/java/android/view/ViewGroup.java | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 92dae2efcd718..1a230a5b2bef3 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -8710,14 +8710,14 @@ public class View implements Drawable.Callback, KeyEvent.Callback, } /** - * Adds the children of a given View for accessibility. Since some Views are - * not important for accessibility the children for accessibility are not - * necessarily direct children of the view, rather they are the first level of - * descendants important for accessibility. + * Adds the children of this View relevant for accessibility to the given list + * as output. Since some Views are not important for accessibility the added + * child views are not necessarily direct children of this view, rather they are + * the first level of descendants important for accessibility. * - * @param children The list of children for accessibility. + * @param outChildren The output list that will receive children for accessibility. */ - public void addChildrenForAccessibility(ArrayList children) { + public void addChildrenForAccessibility(ArrayList outChildren) { } diff --git a/core/java/android/view/ViewGroup.java b/core/java/android/view/ViewGroup.java index 2e2ba881425a0..b53d93ca372d6 100644 --- a/core/java/android/view/ViewGroup.java +++ b/core/java/android/view/ViewGroup.java @@ -1919,7 +1919,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager } @Override - public void addChildrenForAccessibility(ArrayList childrenForAccessibility) { + public void addChildrenForAccessibility(ArrayList outChildren) { if (getAccessibilityNodeProvider() != null) { return; } @@ -1930,9 +1930,9 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager View child = children.getChildAt(i); if ((child.mViewFlags & VISIBILITY_MASK) == VISIBLE) { if (child.includeForAccessibility()) { - childrenForAccessibility.add(child); + outChildren.add(child); } else { - child.addChildrenForAccessibility(childrenForAccessibility); + child.addChildrenForAccessibility(outChildren); } } }