Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Protect against NPE while to updating service connection activities." into nyc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2016-05-27 00:08:15 +00:00
committed by Android (Google) Code Review
parent 58f1167ecf d6ac76284d
commit cef12198a7
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/core/java/com/android/server/am/ActiveServices.java
View File

@@ -753,7 +753,7 @@ public final class ActiveServices {
public void updateServiceConnectionActivitiesLocked(ProcessRecord clientProc) { public void updateServiceConnectionActivitiesLocked(ProcessRecord clientProc) {
ArraySet<ProcessRecord> updatedProcesses = null; ArraySet<ProcessRecord> updatedProcesses = null;
for (int i=0; i<clientProc.connections.size(); i++) { for (int i = 0; i < clientProc.connections.size(); i++) {
final ConnectionRecord conn = clientProc.connections.valueAt(i); final ConnectionRecord conn = clientProc.connections.valueAt(i);
final ProcessRecord proc = conn.binding.service.app; final ProcessRecord proc = conn.binding.service.app;
if (proc == null || proc == clientProc) { if (proc == null || proc == clientProc) {

4
services/core/java/com/android/server/am/ActivityStackSupervisor.java
View File

@@ -1338,7 +1338,9 @@ public final class ActivityStackSupervisor implements DisplayListener {
// Update any services we are bound to that might care about whether // Update any services we are bound to that might care about whether
// their client may have activities. // their client may have activities.
mService.mServices.updateServiceConnectionActivitiesLocked(r.app); if (r.app != null) {
mService.mServices.updateServiceConnectionActivitiesLocked(r.app);
}
return true; return true;
} }