From ca6e67a66ba3448b00bd24762ab9494fb54fa8cd Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Fri, 3 Mar 2023 17:55:09 +0000 Subject: [PATCH 1/2] Ready more build rules for dir move Tweak some visibilities and set up more filegroups to enable moving the ApiDocs.bp and StubLibraries.bp files into the api subdir. Bug: 271563074 Test: m Change-Id: Ib2776dfc6c67b2042fb2f43a1251cd6f0ba61dc7 --- Android.bp | 11 ++++------- ApiDocs.bp | 10 +++++----- StubLibraries.bp | 1 + core/java/Android.bp | 5 +++++ mime/java/Android.bp | 5 ++++- 5 files changed, 19 insertions(+), 13 deletions(-) diff --git a/Android.bp b/Android.bp index 93d1e4e5b0209..fe426e779561d 100644 --- a/Android.bp +++ b/Android.bp @@ -532,7 +532,7 @@ filegroup { "core/java/**/*.logtags", "**/package.html", ], - visibility: ["//visibility:private"], + visibility: ["//frameworks/base/api"], } // Defaults for all stubs that include the non-updatable framework. These defaults do not include @@ -546,12 +546,10 @@ stubs_defaults { java_version: "1.8", arg_files: [":frameworks-base-core-AndroidManifest.xml"], aidl: { - local_include_dirs: [ - "media/aidl", - "telephony/java", - ], include_dirs: [ "frameworks/av/aidl", + "frameworks/base/media/aidl", + "frameworks/base/telephony/java", "frameworks/native/libs/permission/aidl", "packages/modules/Bluetooth/framework/aidl-export", "packages/modules/Connectivity/framework/aidl-export", @@ -583,7 +581,7 @@ stubs_defaults { annotations_enabled: true, previous_api: ":android.api.public.latest", merge_annotations_dirs: ["metalava-manual"], - defaults_visibility: ["//visibility:private"], + defaults_visibility: ["//frameworks/base/api"], visibility: ["//frameworks/base/api"], } @@ -611,7 +609,6 @@ stubs_defaults { // NOTE: The below can be removed once the prebuilt stub contains IKE. "sdk_system_current_android.net.ipsec.ike", ], - defaults_visibility: ["//visibility:private"], } build = [ diff --git a/ApiDocs.bp b/ApiDocs.bp index a46ecce5c7219..fbcaa52f9bb4b 100644 --- a/ApiDocs.bp +++ b/ApiDocs.bp @@ -182,10 +182,10 @@ droidstubs { // using droiddoc ///////////////////////////////////////////////////////////////////// -framework_docs_only_args = " -android -manifest $(location core/res/AndroidManifest.xml) " + +framework_docs_only_args = " -android -manifest $(location :frameworks-base-core-AndroidManifest.xml) " + "-metalavaApiSince " + "-werror -lerror -hide 111 -hide 113 -hide 125 -hide 126 -hide 127 -hide 128 " + - "-overview $(location core/java/overview.html) " + + "-overview $(location :frameworks-base-java-overview) " + // Federate Support Library references against local API file. "-federate SupportLib https://developer.android.com " + "-federationapi SupportLib $(location :current-support-api) " + @@ -218,16 +218,16 @@ doc_defaults { "sdk.preview 0", ], arg_files: [ - "core/res/AndroidManifest.xml", - "core/java/overview.html", + ":frameworks-base-core-AndroidManifest.xml", + ":frameworks-base-java-overview", ":current-support-api", ":current-androidx-api", ], // TODO(b/169090544): remove below aidl includes. aidl: { - local_include_dirs: ["media/aidl"], include_dirs: [ "frameworks/av/aidl", + "frameworks/base/media/aidl", "frameworks/native/libs/permission/aidl", ], }, diff --git a/StubLibraries.bp b/StubLibraries.bp index b005591980c07..f08745b5cd2c2 100644 --- a/StubLibraries.bp +++ b/StubLibraries.bp @@ -515,6 +515,7 @@ droidstubs { ], api_levels_sdk_type: "public", extensions_info_file: ":sdk-extensions-info", + visibility: ["//frameworks/base"], } droidstubs { diff --git a/core/java/Android.bp b/core/java/Android.bp index 7df3d1e13aa04..8ceea92957edb 100644 --- a/core/java/Android.bp +++ b/core/java/Android.bp @@ -429,6 +429,11 @@ aidl_interface { }, } +filegroup { + name: "frameworks-base-java-overview", + srcs: ["overview.html"], +} + // Avoid including Parcelable classes as we don't want to have two copies of // Parcelable cross the libraries. This is used by telephony-common (frameworks/opt/telephony) // and TeleService app (packages/services/Telephony). diff --git a/mime/java/Android.bp b/mime/java/Android.bp index 07cada8e1372b..a267d6593f659 100644 --- a/mime/java/Android.bp +++ b/mime/java/Android.bp @@ -10,5 +10,8 @@ package { filegroup { name: "framework-mime-sources", srcs: ["**/*.java"], - visibility: ["//frameworks/base"], + visibility: [ + "//frameworks/base", + "//frameworks/base/api", + ], } From 19fcec6c634c28c1a842d7164d94a46b3ef59942 Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Tue, 2 May 2023 08:57:12 +0000 Subject: [PATCH 2/2] Move ApiDocs.bp and StubLibraries.bp to api dir Make a symlink from api/docs -> docs, since many places are hardcoding the path fw/base/docs. Bug: 271563074 Test: presubmit Change-Id: I354f3cb62535f34d8819d158e53aa46ff26dc18a --- Android.bp | 2 -- api/Android.bp | 5 +++++ ApiDocs.bp => api/ApiDocs.bp | 0 StubLibraries.bp => api/StubLibraries.bp | 0 api/docs | 1 + 5 files changed, 6 insertions(+), 2 deletions(-) rename ApiDocs.bp => api/ApiDocs.bp (100%) rename StubLibraries.bp => api/StubLibraries.bp (100%) create mode 120000 api/docs diff --git a/Android.bp b/Android.bp index fe426e779561d..b4e02c0a092f7 100644 --- a/Android.bp +++ b/Android.bp @@ -612,8 +612,6 @@ stubs_defaults { } build = [ - "StubLibraries.bp", - "ApiDocs.bp", "ProtoLibraries.bp", "TestProtoLibraries.bp", ] diff --git a/api/Android.bp b/api/Android.bp index 9d20eca75f8f7..f40f0c990f72b 100644 --- a/api/Android.bp +++ b/api/Android.bp @@ -252,3 +252,8 @@ java_genrule { out: ["api_fingerprint.txt"], cmd: "cat $(in) | md5sum | cut -d' ' -f1 > $(out)", } + +build = [ + "ApiDocs.bp", + "StubLibraries.bp", +] diff --git a/ApiDocs.bp b/api/ApiDocs.bp similarity index 100% rename from ApiDocs.bp rename to api/ApiDocs.bp diff --git a/StubLibraries.bp b/api/StubLibraries.bp similarity index 100% rename from StubLibraries.bp rename to api/StubLibraries.bp diff --git a/api/docs b/api/docs new file mode 120000 index 0000000000000..a9594bfe4ab69 --- /dev/null +++ b/api/docs @@ -0,0 +1 @@ +../docs \ No newline at end of file