From 553c027bbf1769e25526d3f0c20a57848e393893 Mon Sep 17 00:00:00 2001 From: Jooyung Han Date: Thu, 12 Aug 2021 17:32:38 +0900 Subject: [PATCH] AIDL: use typed Map AIDL supports typed maps, so use it instead of untyped one. Bug: 192615532 Test: m, TH presubmit Change-Id: I0fedf05872cbe2025e04ca07ce6c90bc9067b331 --- core/java/android/app/ActivityThread.java | 7 +++---- core/java/android/app/IApplicationThread.aidl | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/java/android/app/ActivityThread.java b/core/java/android/app/ActivityThread.java index 41170a4c27497..56ec8eae23b67 100644 --- a/core/java/android/app/ActivityThread.java +++ b/core/java/android/app/ActivityThread.java @@ -1041,17 +1041,16 @@ public final class ActivityThread extends ClientTransactionHandler { IUiAutomationConnection instrumentationUiConnection, int debugMode, boolean enableBinderTracking, boolean trackAllocation, boolean isRestrictedBackupMode, boolean persistent, Configuration config, - CompatibilityInfo compatInfo, Map services, Bundle coreSettings, + CompatibilityInfo compatInfo, Map services, Bundle coreSettings, String buildSerial, AutofillOptions autofillOptions, ContentCaptureOptions contentCaptureOptions, long[] disabledCompatChanges) { if (services != null) { if (false) { // Test code to make sure the app could see the passed-in services. - for (Object oname : services.keySet()) { - if (services.get(oname) == null) { + for (String name : services.keySet()) { + if (services.get(name) == null) { continue; // AM just passed in a null service. } - String name = (String) oname; // See b/79378449 about the following exemption. switch (name) { diff --git a/core/java/android/app/IApplicationThread.aidl b/core/java/android/app/IApplicationThread.aidl index 6e9157e2a8c32..45a83884c6b15 100644 --- a/core/java/android/app/IApplicationThread.aidl +++ b/core/java/android/app/IApplicationThread.aidl @@ -72,7 +72,7 @@ oneway interface IApplicationThread { IInstrumentationWatcher testWatcher, IUiAutomationConnection uiAutomationConnection, int debugMode, boolean enableBinderTracking, boolean trackAllocation, boolean restrictedBackupMode, boolean persistent, in Configuration config, - in CompatibilityInfo compatInfo, in Map services, + in CompatibilityInfo compatInfo, in Map services, in Bundle coreSettings, in String buildSerial, in AutofillOptions autofillOptions, in ContentCaptureOptions contentCaptureOptions, in long[] disabledCompatChanges); void runIsolatedEntryPoint(in String entryPoint, in String[] entryPointArgs);