diff --git a/core/java/android/os/SharedMemory.java b/core/java/android/os/SharedMemory.java index 0540e3611b52c..7df4b5d8f63b2 100644 --- a/core/java/android/os/SharedMemory.java +++ b/core/java/android/os/SharedMemory.java @@ -25,6 +25,8 @@ import android.system.OsConstants; import dalvik.system.VMRuntime; +import libcore.io.IoUtils; + import java.io.Closeable; import java.io.FileDescriptor; import java.nio.ByteBuffer; @@ -293,21 +295,24 @@ public final class SharedMemory implements Parcelable, Closeable { * Cleaner that closes the FD */ private static final class Closer implements Runnable { - private int mFd; + // This is a copy of the FileDescriptor we're attached to, in order to avoid a reference + // cycle. + private FileDescriptor mFd; private MemoryRegistration mMemoryReference; private Closer(int fd, MemoryRegistration memoryReference) { - mFd = fd; + mFd = new FileDescriptor(); + mFd.setInt$(fd); + IoUtils.setFdOwner(mFd, this); + mMemoryReference = memoryReference; } @Override public void run() { - try { - FileDescriptor fd = new FileDescriptor(); - fd.setInt$(mFd); - Os.close(fd); - } catch (ErrnoException e) { /* swallow error */ } + IoUtils.closeQuietly(mFd); + mFd = null; + mMemoryReference.release(); mMemoryReference = null; } diff --git a/services/core/java/com/android/server/GraphicsStatsService.java b/services/core/java/com/android/server/GraphicsStatsService.java index 4639d7586f837..70569db5e2d3f 100644 --- a/services/core/java/com/android/server/GraphicsStatsService.java +++ b/services/core/java/com/android/server/GraphicsStatsService.java @@ -191,7 +191,7 @@ public class GraphicsStatsService extends IGraphicsStats.Stub { if (!file.getFileDescriptor().valid()) { throw new IllegalStateException("Invalid file descriptor"); } - return new ParcelFileDescriptor(file.getFileDescriptor()); + return ParcelFileDescriptor.dup(file.getFileDescriptor()); } catch (IOException ex) { throw new IllegalStateException("Failed to get PFD from memory file", ex); }