From 27bd37ff3aa4a4b0f84341cb576df7b75596450a Mon Sep 17 00:00:00 2001 From: Fyodor Kupolov Date: Thu, 21 Apr 2016 11:26:14 -0700 Subject: [PATCH] Remove pre-N db after successful migration Bug: 26279712 Change-Id: I53e4bd1b04b4ae6b94e8b5642d7f11a4edd6f1e4 --- .../server/accounts/AccountManagerService.java | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/services/core/java/com/android/server/accounts/AccountManagerService.java b/services/core/java/com/android/server/accounts/AccountManagerService.java index 47918187e22ae..87dedc91181f3 100644 --- a/services/core/java/com/android/server/accounts/AccountManagerService.java +++ b/services/core/java/com/android/server/accounts/AccountManagerService.java @@ -4696,26 +4696,20 @@ public class AccountManagerService ceHelper.getWritableDatabase(); ceHelper.close(); if (removeOldDb) { - // TODO STOPSHIP - backup file during testing. Remove file before the release - Log.i(TAG, "Migration complete - creating backup of old db " + preNDatabaseFile); - renameToBakFile(preNDatabaseFile); + Slog.i(TAG, "Migration complete - removing pre-N db " + preNDatabaseFile); + if (!SQLiteDatabase.deleteDatabase(preNDatabaseFile)) { + Slog.e(TAG, "Cannot remove pre-N db " + preNDatabaseFile); + } } return ceHelper; } - private static void renameToBakFile(File file) { - File bakFile = new File(file.getPath() + ".bak"); - if (!file.renameTo(bakFile)) { - Log.e(TAG, "Cannot move file to " + bakFile); - } - } - private static boolean migratePreNDbToCe(File oldDbFile, File ceDbFile) { - Log.i(TAG, "Moving pre-N DB " + oldDbFile + " to CE " + ceDbFile); + Slog.i(TAG, "Moving pre-N DB " + oldDbFile + " to CE " + ceDbFile); try { FileUtils.copyFileOrThrow(oldDbFile, ceDbFile); } catch (IOException e) { - Log.e(TAG, "Cannot copy file to " + ceDbFile + " from " + oldDbFile, e); + Slog.e(TAG, "Cannot copy file to " + ceDbFile + " from " + oldDbFile, e); // Try to remove potentially damaged file if I/O error occurred deleteDbFileWarnIfFailed(ceDbFile); return false;