Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Log package parse timings" into oc-mr1-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2017-08-01 19:46:29 +00:00
committed by Android (Google) Code Review
parent 7fecc73f52 28a988f7d5
commit cd0d29e9fc
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/java/android/content/pm/PackageParser.java
View File

@@ -64,6 +64,7 @@ import android.os.FileUtils;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
import android.os.PatternMatcher; import android.os.PatternMatcher;
import android.os.SystemClock;
import android.os.SystemProperties; import android.os.SystemProperties;
import android.os.Trace; import android.os.Trace;
import android.os.UserHandle; import android.os.UserHandle;
@@ -145,6 +146,8 @@ public class PackageParser {
private static final boolean DEBUG_JAR = false; private static final boolean DEBUG_JAR = false;
private static final boolean DEBUG_PARSER = false; private static final boolean DEBUG_PARSER = false;
private static final boolean DEBUG_BACKUP = false; private static final boolean DEBUG_BACKUP = false;
private static final boolean LOG_PARSE_TIMINGS = Build.IS_DEBUGGABLE;
private static final int LOG_PARSE_TIMINGS_THRESHOLD_MS = 100;
private static final String PROPERTY_CHILD_PACKAGES_ENABLED = private static final String PROPERTY_CHILD_PACKAGES_ENABLED =
"persist.sys.child_packages_enabled"; "persist.sys.child_packages_enabled";
@@ -993,14 +996,23 @@ public class PackageParser {
return parsed; return parsed;
} }
long parseTime = LOG_PARSE_TIMINGS ? SystemClock.uptimeMillis() : 0;
if (packageFile.isDirectory()) { if (packageFile.isDirectory()) {
parsed = parseClusterPackage(packageFile, flags); parsed = parseClusterPackage(packageFile, flags);
} else { } else {
parsed = parseMonolithicPackage(packageFile, flags); parsed = parseMonolithicPackage(packageFile, flags);
} }
long cacheTime = LOG_PARSE_TIMINGS ? SystemClock.uptimeMillis() : 0;
cacheResult(packageFile, flags, parsed); cacheResult(packageFile, flags, parsed);
if (LOG_PARSE_TIMINGS) {
parseTime = cacheTime - parseTime;
cacheTime = SystemClock.uptimeMillis() - cacheTime;
if (parseTime + cacheTime > LOG_PARSE_TIMINGS_THRESHOLD_MS) {
Slog.i(TAG, "Parse times for '" + packageFile + "': parse=" + parseTime
+ "ms, update_cache=" + cacheTime + " ms");
}
}
return parsed; return parsed;
} }