From ccf6e88eec6081f83b21e97d930205fa5419583e Mon Sep 17 00:00:00 2001 From: Eino-Ville Talvala Date: Wed, 28 Jan 2015 12:55:12 -0800 Subject: [PATCH] Camera2 legacy: Do not advertise NV21 support. Also reduce logging somewhat for common scenarios. Bug: 19161738 Change-Id: If96ed7d2bac0229159564072d7969d7bea3fae27 --- .../camera2/legacy/LegacyMetadataMapper.java | 12 ++++++------ .../android/hardware/camera2/utils/ArrayUtils.java | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/java/android/hardware/camera2/legacy/LegacyMetadataMapper.java b/core/java/android/hardware/camera2/legacy/LegacyMetadataMapper.java index 03540e12a428b..347db05b930c3 100644 --- a/core/java/android/hardware/camera2/legacy/LegacyMetadataMapper.java +++ b/core/java/android/hardware/camera2/legacy/LegacyMetadataMapper.java @@ -328,15 +328,15 @@ public class LegacyMetadataMapper { appendStreamConfig(availableStreamConfigs, ImageFormat.YUV_420_888, previewSizes); for (int format : p.getSupportedPreviewFormats()) { - if (ImageFormat.isPublicFormat(format)) { + if (ImageFormat.isPublicFormat(format) && format != ImageFormat.NV21) { appendStreamConfig(availableStreamConfigs, format, previewSizes); - } else { + } else if (VERBOSE) { /* * Do not add any formats unknown to us * (since it would fail runtime checks in StreamConfigurationMap) */ - Log.w(TAG, - String.format("mapStreamConfigs - Skipping non-public format %x", format)); + Log.v(TAG, + String.format("mapStreamConfigs - Skipping format %x", format)); } } @@ -389,8 +389,8 @@ public class LegacyMetadataMapper { int j = 0; for (String mode : antiBandingModes) { int convertedMode = convertAntiBandingMode(mode); - if (convertedMode == -1) { - Log.w(TAG, "Antibanding mode " + ((mode == null) ? "NULL" : mode) + + if (VERBOSE && convertedMode == -1) { + Log.v(TAG, "Antibanding mode " + ((mode == null) ? "NULL" : mode) + " not supported, skipping..."); } else { modes[j++] = convertedMode; diff --git a/core/java/android/hardware/camera2/utils/ArrayUtils.java b/core/java/android/hardware/camera2/utils/ArrayUtils.java index 5a78bbd4b9498..79a335ccb2e23 100644 --- a/core/java/android/hardware/camera2/utils/ArrayUtils.java +++ b/core/java/android/hardware/camera2/utils/ArrayUtils.java @@ -117,7 +117,7 @@ public class ArrayUtils { // Guard against unexpected values if (strIndex < 0) { - Log.w(TAG, "Ignoring invalid value " + str); + if (VERBOSE) Log.v(TAG, "Ignoring invalid value " + str); continue; }