From 275708c82cad1119d645b4be533b1ad0088e148c Mon Sep 17 00:00:00 2001 From: Nick Pelly Date: Tue, 2 Nov 2010 16:13:52 -0500 Subject: [PATCH] Remove timeout support. The implementation was guarenteed to cause deadlock when a timeout was set. Change-Id: I59444ea784eb9057c6c4c9e9123f558b3ef5eef6 Signed-off-by: Nick Pelly --- core/java/android/nfc/ILlcpServiceSocket.aidl | 2 -- core/java/android/nfc/ILlcpSocket.aidl | 2 -- .../internal/nfc/LlcpServiceSocket.java | 28 ------------------- .../com/android/internal/nfc/LlcpSocket.java | 28 ------------------- 4 files changed, 60 deletions(-) diff --git a/core/java/android/nfc/ILlcpServiceSocket.aidl b/core/java/android/nfc/ILlcpServiceSocket.aidl index c3108dc4c7de4..581c21dad6ae4 100644 --- a/core/java/android/nfc/ILlcpServiceSocket.aidl +++ b/core/java/android/nfc/ILlcpServiceSocket.aidl @@ -23,6 +23,4 @@ interface ILlcpServiceSocket { int accept(int nativeHandle); void close(int nativeHandle); - int getAcceptTimeout(int nativeHandle); - void setAcceptTimeout(int nativeHandle, int timeout); } diff --git a/core/java/android/nfc/ILlcpSocket.aidl b/core/java/android/nfc/ILlcpSocket.aidl index dda5628286e9e..3166e72964dd3 100644 --- a/core/java/android/nfc/ILlcpSocket.aidl +++ b/core/java/android/nfc/ILlcpSocket.aidl @@ -24,7 +24,6 @@ interface ILlcpSocket int close(int nativeHandle); int connect(int nativeHandle, int sap); int connectByName(int nativeHandle, String sn); - int getConnectTimeout(int nativeHandle); int getLocalSap(int nativeHandle); int getLocalSocketMiu(int nativeHandle); int getLocalSocketRw(int nativeHandle); @@ -32,5 +31,4 @@ interface ILlcpSocket int getRemoteSocketRw(int nativeHandle); int receive(int nativeHandle, out byte[] receiveBuffer); int send(int nativeHandle, in byte[] data); - void setConnectTimeout(int nativeHandle, int timeout); } \ No newline at end of file diff --git a/core/java/com/android/internal/nfc/LlcpServiceSocket.java b/core/java/com/android/internal/nfc/LlcpServiceSocket.java index 318982b721a1b..d61686023eff2 100644 --- a/core/java/com/android/internal/nfc/LlcpServiceSocket.java +++ b/core/java/com/android/internal/nfc/LlcpServiceSocket.java @@ -121,34 +121,6 @@ public class LlcpServiceSocket { } - /** - * Set the timeout for the accept request - * - * @param timeout - * value of the timeout for the accept request - */ - public void setAcceptTimeout(int timeout) { - try { - mService.setAcceptTimeout(mHandle, timeout); - } catch (RemoteException e) { - Log.e(TAG, "RemoteException in setAcceptTimeout(): ", e); - } - } - - /** - * Get the timeout value of the accept request - * - * @return mTimeout - */ - public int getAcceptTimeout() { - try { - return mService.getAcceptTimeout(mHandle); - } catch (RemoteException e) { - Log.e(TAG, "RemoteException in getAcceptTimeout(): ", e); - return 0; - } - } - /** * Close the created Llcp Service socket */ diff --git a/core/java/com/android/internal/nfc/LlcpSocket.java b/core/java/com/android/internal/nfc/LlcpSocket.java index b1b132034b4c4..73c09259e77f0 100644 --- a/core/java/com/android/internal/nfc/LlcpSocket.java +++ b/core/java/com/android/internal/nfc/LlcpSocket.java @@ -139,34 +139,6 @@ public class LlcpSocket { } } - /** - * Set the timeout for the connect request - * - * @param timeout - * timeout value for the connect request - */ - public void setConnectTimeout(int timeout) { - try { - mService.setConnectTimeout(mHandle, timeout); - } catch (RemoteException e) { - Log.e(TAG, "RemoteException in setConnectTimeout(): ", e); - } - } - - /** - * Get the timeout value of the connect request - * - * @return mTimeout - */ - public int getConnectTimeout() { - try { - return mService.getConnectTimeout(mHandle); - } catch (RemoteException e) { - Log.e(TAG, "RemoteException in getConnectTimeout(): ", e); - return 0; - } - } - /** * Disconnect request to the connected LLCP socket and close the created * socket.