Merge "Avoid instantiations of Boolean that are immediately unboxed." into nyc-dev-plus-aosp

This commit is contained in:
Tobias Thierer
2016-04-25 09:51:41 +00:00
committed by Android (Google) Code Review
9 changed files with 12 additions and 12 deletions

View File

@@ -570,7 +570,7 @@ public class ZenModeConfig implements Parcelable {
private static boolean safeBoolean(String val, boolean defValue) { private static boolean safeBoolean(String val, boolean defValue) {
if (TextUtils.isEmpty(val)) return defValue; if (TextUtils.isEmpty(val)) return defValue;
return Boolean.valueOf(val); return Boolean.parseBoolean(val);
} }
private static int safeInt(XmlPullParser parser, String att, int defValue) { private static int safeInt(XmlPullParser parser, String att, int defValue) {

View File

@@ -135,7 +135,7 @@ public class VpnProfile implements Cloneable, Parcelable {
profile.dnsServers = values[5]; profile.dnsServers = values[5];
profile.searchDomains = values[6]; profile.searchDomains = values[6];
profile.routes = values[7]; profile.routes = values[7];
profile.mppe = Boolean.valueOf(values[8]); profile.mppe = Boolean.parseBoolean(values[8]);
profile.l2tpSecret = values[9]; profile.l2tpSecret = values[9];
profile.ipsecIdentifier = values[10]; profile.ipsecIdentifier = values[10];
profile.ipsecSecret = values[11]; profile.ipsecSecret = values[11];

View File

@@ -1280,7 +1280,7 @@ public class XmlUtils {
if (eventType == parser.START_TAG) { if (eventType == parser.START_TAG) {
if (parser.getName().equals("item")) { if (parser.getName().equals("item")) {
try { try {
array[i] = Boolean.valueOf(parser.getAttributeValue(null, "value")); array[i] = Boolean.parseBoolean(parser.getAttributeValue(null, "value"));
} catch (NullPointerException e) { } catch (NullPointerException e) {
throw new XmlPullParserException("Need value attribute in item"); throw new XmlPullParserException("Need value attribute in item");
} catch (NumberFormatException e) { } catch (NumberFormatException e) {

View File

@@ -1402,7 +1402,7 @@ final class ActivityRecord {
} else if (ATTR_RESOLVEDTYPE.equals(attrName)) { } else if (ATTR_RESOLVEDTYPE.equals(attrName)) {
resolvedType = attrValue; resolvedType = attrValue;
} else if (ATTR_COMPONENTSPECIFIED.equals(attrName)) { } else if (ATTR_COMPONENTSPECIFIED.equals(attrName)) {
componentSpecified = Boolean.valueOf(attrValue); componentSpecified = Boolean.parseBoolean(attrValue);
} else if (ATTR_USERID.equals(attrName)) { } else if (ATTR_USERID.equals(attrName)) {
userId = Integer.parseInt(attrValue); userId = Integer.parseInt(attrValue);
} else if (attrName.startsWith(TaskDescription.ATTR_TASKDESCRIPTION_PREFIX)) { } else if (attrName.startsWith(TaskDescription.ATTR_TASKDESCRIPTION_PREFIX)) {

View File

@@ -311,7 +311,7 @@ public class RankingHelper implements RankingConfig {
private static boolean tryParseBool(String value, boolean defValue) { private static boolean tryParseBool(String value, boolean defValue) {
if (TextUtils.isEmpty(value)) return defValue; if (TextUtils.isEmpty(value)) return defValue;
return Boolean.valueOf(value); return Boolean.parseBoolean(value);
} }
/** /**

View File

@@ -251,7 +251,7 @@ final class PersistentDataStore {
throw new XmlPullParserException( throw new XmlPullParserException(
"Missing " + ATTR_ENABLED + " attribute on " + TAG_PARENTAL_CONTROLS); "Missing " + ATTR_ENABLED + " attribute on " + TAG_PARENTAL_CONTROLS);
} }
mParentalControlsEnabled = Boolean.valueOf(enabled); mParentalControlsEnabled = Boolean.parseBoolean(enabled);
} }
} }
} }

View File

@@ -998,7 +998,7 @@ public class ServiceState implements Parcelable {
m.putString("data-operator-alpha-long", mDataOperatorAlphaLong); m.putString("data-operator-alpha-long", mDataOperatorAlphaLong);
m.putString("data-operator-alpha-short", mDataOperatorAlphaShort); m.putString("data-operator-alpha-short", mDataOperatorAlphaShort);
m.putString("data-operator-numeric", mDataOperatorNumeric); m.putString("data-operator-numeric", mDataOperatorNumeric);
m.putBoolean("manual", Boolean.valueOf(mIsManualNetworkSelection)); m.putBoolean("manual", mIsManualNetworkSelection);
m.putInt("radioTechnology", mRilVoiceRadioTechnology); m.putInt("radioTechnology", mRilVoiceRadioTechnology);
m.putInt("dataRadioTechnology", mRilDataRadioTechnology); m.putInt("dataRadioTechnology", mRilDataRadioTechnology);
m.putBoolean("cssIndicator", mCssIndicator); m.putBoolean("cssIndicator", mCssIndicator);
@@ -1006,8 +1006,8 @@ public class ServiceState implements Parcelable {
m.putInt("systemId", mSystemId); m.putInt("systemId", mSystemId);
m.putInt("cdmaRoamingIndicator", mCdmaRoamingIndicator); m.putInt("cdmaRoamingIndicator", mCdmaRoamingIndicator);
m.putInt("cdmaDefaultRoamingIndicator", mCdmaDefaultRoamingIndicator); m.putInt("cdmaDefaultRoamingIndicator", mCdmaDefaultRoamingIndicator);
m.putBoolean("emergencyOnly", Boolean.valueOf(mIsEmergencyOnly)); m.putBoolean("emergencyOnly", mIsEmergencyOnly);
m.putBoolean("isDataRoamingFromRegistration", Boolean.valueOf(mIsDataRoamingFromRegistration)); m.putBoolean("isDataRoamingFromRegistration", mIsDataRoamingFromRegistration);
} }
/** @hide */ /** @hide */

View File

@@ -1046,7 +1046,7 @@ public class SignalStrength implements Parcelable {
m.putInt("LteRssnr", mLteRssnr); m.putInt("LteRssnr", mLteRssnr);
m.putInt("LteCqi", mLteCqi); m.putInt("LteCqi", mLteCqi);
m.putInt("TdScdma", mTdScdmaRscp); m.putInt("TdScdma", mTdScdmaRscp);
m.putBoolean("isGsm", Boolean.valueOf(isGsm)); m.putBoolean("isGsm", isGsm);
} }
/** /**

View File

@@ -4883,7 +4883,7 @@ public class TelephonyManager {
*/ */
public boolean getSmsReceiveCapableForPhone(int phoneId, boolean defaultValue) { public boolean getSmsReceiveCapableForPhone(int phoneId, boolean defaultValue) {
if (SubscriptionManager.isValidPhoneId(phoneId)) { if (SubscriptionManager.isValidPhoneId(phoneId)) {
return Boolean.valueOf(TelephonyManager.getTelephonyProperty(phoneId, return Boolean.parseBoolean(TelephonyManager.getTelephonyProperty(phoneId,
TelephonyProperties.PROPERTY_SMS_RECEIVE, String.valueOf(defaultValue))); TelephonyProperties.PROPERTY_SMS_RECEIVE, String.valueOf(defaultValue)));
} }
@@ -4914,7 +4914,7 @@ public class TelephonyManager {
*/ */
public boolean getSmsSendCapableForPhone(int phoneId, boolean defaultValue) { public boolean getSmsSendCapableForPhone(int phoneId, boolean defaultValue) {
if (SubscriptionManager.isValidPhoneId(phoneId)) { if (SubscriptionManager.isValidPhoneId(phoneId)) {
return Boolean.valueOf(TelephonyManager.getTelephonyProperty(phoneId, return Boolean.parseBoolean(TelephonyManager.getTelephonyProperty(phoneId,
TelephonyProperties.PROPERTY_SMS_SEND, String.valueOf(defaultValue))); TelephonyProperties.PROPERTY_SMS_SEND, String.valueOf(defaultValue)));
} }