From cbeadf8f71056b9bb3af3b0b5f8ee7986c44c4b2 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Thu, 13 Oct 2022 23:05:41 -0700 Subject: [PATCH] Partly inline ImeFocusController#updateImeFocusable() This is mechanical refactoring. There must be no observable behavior change. Bug: 234882948 Test: presubmit Change-Id: I0c63504fc7fe665f7b7816bdcc7a6cb357482380 --- core/java/android/view/ImeFocusController.java | 12 ++++-------- core/java/android/view/ViewRootImpl.java | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/core/java/android/view/ImeFocusController.java b/core/java/android/view/ImeFocusController.java index 4f2b62155c488..455f4a76834e1 100644 --- a/core/java/android/view/ImeFocusController.java +++ b/core/java/android/view/ImeFocusController.java @@ -65,7 +65,8 @@ public final class ImeFocusController { @UiThread void onTraversal(boolean hasWindowFocus, WindowManager.LayoutParams windowAttribute) { - final boolean hasImeFocus = updateImeFocusable(windowAttribute, false /* force */); + final boolean hasImeFocus = WindowManager.LayoutParams.mayUseInputMethod( + windowAttribute.flags); if (!hasWindowFocus || isInLocalFocusMode(windowAttribute)) { return; } @@ -90,13 +91,8 @@ public final class ImeFocusController { } @UiThread - boolean updateImeFocusable(WindowManager.LayoutParams windowAttribute, boolean force) { - final boolean hasImeFocus = WindowManager.LayoutParams.mayUseInputMethod( - windowAttribute.flags); - if (force) { - mHasImeFocus = hasImeFocus; - } - return hasImeFocus; + void updateImeFocusable(WindowManager.LayoutParams windowAttribute) { + mHasImeFocus = WindowManager.LayoutParams.mayUseInputMethod(windowAttribute.flags); } @UiThread diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java index b2b5f1356273f..b690b3c5098cb 100644 --- a/core/java/android/view/ViewRootImpl.java +++ b/core/java/android/view/ViewRootImpl.java @@ -3798,7 +3798,7 @@ public final class ViewRootImpl implements ViewParent, } mAttachInfo.mHasWindowFocus = hasWindowFocus; - mImeFocusController.updateImeFocusable(mWindowAttributes, true /* force */); + mImeFocusController.updateImeFocusable(mWindowAttributes); mImeFocusController.onPreWindowFocus(hasWindowFocus, mWindowAttributes); if (mView != null) {