From cbdd03ffad756ec74040afcedb282ef4de45d9fc Mon Sep 17 00:00:00 2001 From: tsaichristine Date: Tue, 14 Jan 2020 15:29:23 -0800 Subject: [PATCH] Remove repeated function ValidateUidDimension and ValidateAttributionUidDimension do the same thing, and ValidateUidDimension is not used in any testing code. Test: bit statsd_test:* Change-Id: If3e2ad300f36ef3232deeb4f04d325ae3a29719c --- cmds/statsd/tests/statsd_test_util.cpp | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/cmds/statsd/tests/statsd_test_util.cpp b/cmds/statsd/tests/statsd_test_util.cpp index 7b651dfed7fc7..e0aecceac4e3a 100644 --- a/cmds/statsd/tests/statsd_test_util.cpp +++ b/cmds/statsd/tests/statsd_test_util.cpp @@ -616,19 +616,6 @@ int64_t StringToId(const string& str) { } void ValidateAttributionUidDimension(const DimensionsValue& value, int atomId, int uid) { - EXPECT_EQ(value.field(), atomId); - // Attribution field. - EXPECT_EQ(value.value_tuple().dimensions_value(0).field(), 1); - // Uid only. - EXPECT_EQ(value.value_tuple().dimensions_value(0) - .value_tuple().dimensions_value_size(), 1); - EXPECT_EQ(value.value_tuple().dimensions_value(0) - .value_tuple().dimensions_value(0).field(), 1); - EXPECT_EQ(value.value_tuple().dimensions_value(0) - .value_tuple().dimensions_value(0).value_int(), uid); -} - -void ValidateUidDimension(const DimensionsValue& value, int atomId, int uid) { EXPECT_EQ(value.field(), atomId); EXPECT_EQ(value.value_tuple().dimensions_value_size(), 1); // Attribution field.