From be530ca6713569d33f9ed78df590b3446139dbfa Mon Sep 17 00:00:00 2001
From: Jonathan Basseri <misterikkit@google.com>
Date: Thu, 19 Oct 2017 16:22:08 +0000
Subject: [PATCH] DO NOT MERGE Revert "Convert ICarrierService to oneway."

This reverts commit 49b54d64ca5c2aa08021c2ad747597cdd4486ad8.

Bug: 63400667
Change-Id: Ica0696bf4ae3f9a84f0e4ad6e1207374696e9497
---
 .../service/carrier/CarrierService.java       | 26 +++----------------
 .../service/carrier/ICarrierService.aidl      |  3 +--
 2 files changed, 4 insertions(+), 25 deletions(-)

diff --git a/core/java/android/service/carrier/CarrierService.java b/core/java/android/service/carrier/CarrierService.java
index 2707f1467bcfe..813acc232289e 100644
--- a/core/java/android/service/carrier/CarrierService.java
+++ b/core/java/android/service/carrier/CarrierService.java
@@ -17,13 +17,10 @@ package android.service.carrier;
 import android.annotation.CallSuper;
 import android.app.Service;
 import android.content.Intent;
-import android.os.Bundle;
 import android.os.IBinder;
 import android.os.PersistableBundle;
 import android.os.RemoteException;
-import android.os.ResultReceiver;
 import android.os.ServiceManager;
-import android.util.Log;
 
 import com.android.internal.telephony.ITelephonyRegistry;
 
@@ -51,8 +48,6 @@ import com.android.internal.telephony.ITelephonyRegistry;
  */
 public abstract class CarrierService extends Service {
 
-    private static final String LOG_TAG = "CarrierService";
-
     public static final String CARRIER_SERVICE_INTERFACE = "android.service.carrier.CarrierService";
 
     private static ITelephonyRegistry sRegistry;
@@ -138,26 +133,11 @@ public abstract class CarrierService extends Service {
     /**
      * A wrapper around ICarrierService that forwards calls to implementations of
      * {@link CarrierService}.
-     * @hide
      */
-    public class ICarrierServiceWrapper extends ICarrierService.Stub {
-        /** @hide */
-        public static final int RESULT_OK = 0;
-        /** @hide */
-        public static final int RESULT_ERROR = 1;
-        /** @hide */
-        public static final String KEY_CONFIG_BUNDLE = "config_bundle";
-
+    private class ICarrierServiceWrapper extends ICarrierService.Stub {
         @Override
-        public void getCarrierConfig(CarrierIdentifier id, ResultReceiver result) {
-            try {
-                Bundle data = new Bundle();
-                data.putParcelable(KEY_CONFIG_BUNDLE, CarrierService.this.onLoadConfig(id));
-                result.send(RESULT_OK, data);
-            } catch (Exception e) {
-                Log.e(LOG_TAG, "Error in onLoadConfig: " + e.getMessage(), e);
-                result.send(RESULT_ERROR, null);
-            }
+        public PersistableBundle getCarrierConfig(CarrierIdentifier id) {
+            return CarrierService.this.onLoadConfig(id);
         }
     }
 }
diff --git a/core/java/android/service/carrier/ICarrierService.aidl b/core/java/android/service/carrier/ICarrierService.aidl
index ac6f9614d8f5a..4c875851cfc84 100644
--- a/core/java/android/service/carrier/ICarrierService.aidl
+++ b/core/java/android/service/carrier/ICarrierService.aidl
@@ -17,7 +17,6 @@
 package android.service.carrier;
 
 import android.os.PersistableBundle;
-import android.os.ResultReceiver;
 import android.service.carrier.CarrierIdentifier;
 
 /**
@@ -29,5 +28,5 @@ import android.service.carrier.CarrierIdentifier;
 interface ICarrierService {
 
     /** @see android.service.carrier.CarrierService#onLoadConfig */
-    oneway void getCarrierConfig(in CarrierIdentifier id, in ResultReceiver result);
+    PersistableBundle getCarrierConfig(in CarrierIdentifier id);
 }