From caf2293885ddc754522018353cfb55f619a92f24 Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Fri, 10 Sep 2021 19:55:33 +0000 Subject: [PATCH] New pipeline: remove non-silent section headers Fixes: 204127880 Bug: 199765418 Test: manual Merged-In: I729cca549154c5762c2bb7082111d19b3ec1f9d9 Change-Id: I729cca549154c5762c2bb7082111d19b3ec1f9d9 --- .../collection/coordinator/ConversationCoordinator.kt | 4 +++- .../collection/coordinator/HeadsUpCoordinator.java | 6 +++++- .../collection/coordinator/RankingCoordinator.java | 7 ++++++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/ConversationCoordinator.kt b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/ConversationCoordinator.kt index f0eb084ea8ef3..efec94f547dc6 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/ConversationCoordinator.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/ConversationCoordinator.kt @@ -48,7 +48,9 @@ class ConversationCoordinator @Inject constructor( val sectioner = object : NotifSectioner("People") { override fun isInSection(entry: ListEntry): Boolean = isConversation(entry.representativeEntry!!) - override fun getHeaderNodeController() = peopleHeaderController + override fun getHeaderNodeController() = + // TODO: remove SHOW_ALL_SECTIONS, this redundant method, and peopleHeaderController + if (RankingCoordinator.SHOW_ALL_SECTIONS) peopleHeaderController else null } override fun attach(pipeline: NotifPipeline) { diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/HeadsUpCoordinator.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/HeadsUpCoordinator.java index 6e98c27fe9a96..1bde312d02712 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/HeadsUpCoordinator.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/HeadsUpCoordinator.java @@ -205,7 +205,11 @@ public class HeadsUpCoordinator implements Coordinator { @Nullable @Override public NodeController getHeaderNodeController() { - return mIncomingHeaderController; + // TODO: remove SHOW_ALL_SECTIONS, this redundant method, and mIncomingHeaderController + if (RankingCoordinator.SHOW_ALL_SECTIONS) { + return mIncomingHeaderController; + } + return null; } }; diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/RankingCoordinator.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/RankingCoordinator.java index 6da4d8b709442..d556e97c1bc6b 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/RankingCoordinator.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/RankingCoordinator.java @@ -41,6 +41,7 @@ import javax.inject.Inject; */ @SysUISingleton public class RankingCoordinator implements Coordinator { + public static final boolean SHOW_ALL_SECTIONS = false; private final StatusBarStateController mStatusBarStateController; private final HighPriorityProvider mHighPriorityProvider; private final NodeController mSilentHeaderController; @@ -83,7 +84,11 @@ public class RankingCoordinator implements Coordinator { @Nullable @Override public NodeController getHeaderNodeController() { - return mAlertingHeaderController; + // TODO: remove SHOW_ALL_SECTIONS, this redundant method, and mAlertingHeaderController + if (SHOW_ALL_SECTIONS) { + return mAlertingHeaderController; + } + return null; } };