Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix some dimens in dialog" into sc-qpr1-dev am: 38c00180bc

Browse Source 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15886624

Change-Id: Icfa97d96e9df89198dd6fba22dc25b5dee50fe70
This commit is contained in:
Fabian Kozynski
2021-09-23 13:32:58 +00:00
committed by Automerger Merge Worker
parent 80cdaeed67 38c00180bc
commit cae330719f
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/res/layout/privacy_dialog.xml
View File

@@ -24,9 +24,9 @@
android:layout_marginEnd="@dimen/ongoing_appops_dialog_side_margins" android:layout_marginEnd="@dimen/ongoing_appops_dialog_side_margins"
android:layout_marginTop="8dp" android:layout_marginTop="8dp"
android:orientation="vertical" android:orientation="vertical"
android:paddingBottom="12dp" android:paddingBottom="8dp"
android:paddingTop="8dp" android:paddingTop="12dp"
android:paddingHorizontal="@dimen/ongoing_appops_dialog_side_padding"
android:background="@drawable/qs_dialog_bg" android:background="@drawable/qs_dialog_bg"
/> />
<!-- 12dp padding bottom so there's 20dp total under the icon --> <!-- 8dp padding bottom so there's 16dp total under the icon -->
<!-- 8dp padding top, as there's 4dp margin in each row -->

2
packages/SystemUI/res/layout/privacy_dialog_item.xml
View File

@@ -24,8 +24,6 @@
android:layout_marginTop="4dp" android:layout_marginTop="4dp"
android:importantForAccessibility="yes" android:importantForAccessibility="yes"
android:background="?android:attr/selectableItemBackground" android:background="?android:attr/selectableItemBackground"
android:paddingLeft="@dimen/ongoing_appops_dialog_side_padding"
android:paddingRight="@dimen/ongoing_appops_dialog_side_padding"
android:focusable="true" android:focusable="true"
> >
<!-- 4dp marginTop makes 20dp minimum between icons --> <!-- 4dp marginTop makes 20dp minimum between icons -->

2
packages/SystemUI/res/values/dimens.xml
View File

@@ -1273,7 +1273,7 @@
<dimen name="ongoing_appops_dialog_circle_size">32dp</dimen> <dimen name="ongoing_appops_dialog_circle_size">32dp</dimen>
<dimen name="ongoing_appops_dialog_icon_size">20dp</dimen> <dimen name="ongoing_appops_dialog_icon_size">16dp</dimen>
<dimen name="ongoing_appops_dialog_side_padding">16dp</dimen> <dimen name="ongoing_appops_dialog_side_padding">16dp</dimen>