Merge "fix an NPE in SyncManager's dump where it can get a null AuthorityInfo; instead create one if one doesn't exist yet"

This commit is contained in:
Fred Quintana
2010-02-10 11:45:47 -08:00
committed by Android (Google) Code Review
2 changed files with 5 additions and 3 deletions

View File

@@ -1041,7 +1041,7 @@ public class SyncManager implements OnAccountsUpdateListener {
continue;
}
SyncStorageEngine.AuthorityInfo settings = mSyncStorageEngine.getAuthority(
SyncStorageEngine.AuthorityInfo settings = mSyncStorageEngine.getOrCreateAuthority(
account, syncAdapterType.type.authority);
SyncStatusInfo status = mSyncStorageEngine.getOrCreateSyncStatus(settings);
pw.print(" "); pw.print(settings.authority);

View File

@@ -632,9 +632,11 @@ public class SyncStorageEngine extends Handler {
}
}
public AuthorityInfo getAuthority(Account account, String authority) {
public AuthorityInfo getOrCreateAuthority(Account account, String authority) {
synchronized (mAuthorities) {
return getAuthorityLocked(account, authority, null);
return getOrCreateAuthorityLocked(account, authority,
-1 /* assign a new identifier if creating a new authority */,
true /* write to storage if this results in a change */);
}
}