diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java index d22415e80f322..5cad7db60eca3 100644 --- a/core/java/android/view/ViewRootImpl.java +++ b/core/java/android/view/ViewRootImpl.java @@ -1052,25 +1052,24 @@ public final class ViewRootImpl implements ViewParent, } private boolean collectViewAttributes() { - final View.AttachInfo attachInfo = mAttachInfo; - if (attachInfo.mRecomputeGlobalAttributes) { + if (mAttachInfo.mRecomputeGlobalAttributes) { //Log.i(TAG, "Computing view hierarchy attributes!"); - attachInfo.mRecomputeGlobalAttributes = false; - boolean oldScreenOn = attachInfo.mKeepScreenOn; - attachInfo.mKeepScreenOn = false; - attachInfo.mSystemUiVisibility = 0; - attachInfo.mHasSystemUiListeners = false; - mView.dispatchCollectViewAttributes(attachInfo, 0); - attachInfo.mSystemUiVisibility &= ~attachInfo.mDisabledSystemUiVisibility; + mAttachInfo.mRecomputeGlobalAttributes = false; + boolean oldScreenOn = mAttachInfo.mKeepScreenOn; + mAttachInfo.mKeepScreenOn = false; + mAttachInfo.mSystemUiVisibility = 0; + mAttachInfo.mHasSystemUiListeners = false; + mView.dispatchCollectViewAttributes(mAttachInfo, 0); + mAttachInfo.mSystemUiVisibility &= ~mAttachInfo.mDisabledSystemUiVisibility; WindowManager.LayoutParams params = mWindowAttributes; - attachInfo.mSystemUiVisibility |= getImpliedSystemUiVisibility(params); - if (attachInfo.mKeepScreenOn != oldScreenOn - || attachInfo.mSystemUiVisibility != params.subtreeSystemUiVisibility - || attachInfo.mHasSystemUiListeners != params.hasSystemUiListeners) { + mAttachInfo.mSystemUiVisibility |= getImpliedSystemUiVisibility(params); + if (mAttachInfo.mKeepScreenOn != oldScreenOn + || mAttachInfo.mSystemUiVisibility != params.subtreeSystemUiVisibility + || mAttachInfo.mHasSystemUiListeners != params.hasSystemUiListeners) { applyKeepScreenOnFlag(params); - params.subtreeSystemUiVisibility = attachInfo.mSystemUiVisibility; - params.hasSystemUiListeners = attachInfo.mHasSystemUiListeners; - mView.dispatchWindowSystemUiVisiblityChanged(attachInfo.mSystemUiVisibility); + params.subtreeSystemUiVisibility = mAttachInfo.mSystemUiVisibility; + params.hasSystemUiListeners = mAttachInfo.mHasSystemUiListeners; + mView.dispatchWindowSystemUiVisiblityChanged(mAttachInfo.mSystemUiVisibility); return true; } } @@ -1162,8 +1161,7 @@ public final class ViewRootImpl implements ViewParent, * @param m input matrix to modify */ void transformMatrixToGlobal(Matrix m) { - final View.AttachInfo attachInfo = mAttachInfo; - m.postTranslate(attachInfo.mWindowLeft, attachInfo.mWindowTop); + m.postTranslate(mAttachInfo.mWindowLeft, mAttachInfo.mWindowTop); } /** @@ -1173,8 +1171,7 @@ public final class ViewRootImpl implements ViewParent, * @param m input matrix to modify */ void transformMatrixToLocal(Matrix m) { - final View.AttachInfo attachInfo = mAttachInfo; - m.preTranslate(-attachInfo.mWindowLeft, -attachInfo.mWindowTop); + m.preTranslate(-mAttachInfo.mWindowLeft, -mAttachInfo.mWindowTop); } void dispatchApplyInsets(View host) { @@ -1216,8 +1213,6 @@ public final class ViewRootImpl implements ViewParent, int desiredWindowWidth; int desiredWindowHeight; - final View.AttachInfo attachInfo = mAttachInfo; - final int viewVisibility = getHostVisibility(); boolean viewVisibilityChanged = mViewVisibility != viewVisibility || mNewSurfaceNeeded; @@ -1266,10 +1261,10 @@ public final class ViewRootImpl implements ViewParent, // We used to use the following condition to choose 32 bits drawing caches: // PixelFormat.hasAlpha(lp.format) || lp.format == PixelFormat.RGBX_8888 // However, windows are now always 32 bits by default, so choose 32 bits - attachInfo.mUse32BitDrawingCache = true; - attachInfo.mHasWindowFocus = false; - attachInfo.mWindowVisibility = viewVisibility; - attachInfo.mRecomputeGlobalAttributes = false; + mAttachInfo.mUse32BitDrawingCache = true; + mAttachInfo.mHasWindowFocus = false; + mAttachInfo.mWindowVisibility = viewVisibility; + mAttachInfo.mRecomputeGlobalAttributes = false; viewVisibilityChanged = false; mLastConfiguration.setTo(host.getResources().getConfiguration()); mLastSystemUiVisibility = mAttachInfo.mSystemUiVisibility; @@ -1277,8 +1272,8 @@ public final class ViewRootImpl implements ViewParent, if (mViewLayoutDirectionInitial == View.LAYOUT_DIRECTION_INHERIT) { host.setLayoutDirection(mLastConfiguration.getLayoutDirection()); } - host.dispatchAttachedToWindow(attachInfo, 0); - attachInfo.mTreeObserver.dispatchOnWindowAttachedChange(true); + host.dispatchAttachedToWindow(mAttachInfo, 0); + mAttachInfo.mTreeObserver.dispatchOnWindowAttachedChange(true); dispatchApplyInsets(host); //Log.i(TAG, "Screen on initialized: " + attachInfo.mKeepScreenOn); @@ -1295,7 +1290,7 @@ public final class ViewRootImpl implements ViewParent, } if (viewVisibilityChanged) { - attachInfo.mWindowVisibility = viewVisibility; + mAttachInfo.mWindowVisibility = viewVisibility; host.dispatchWindowVisibilityChanged(viewVisibility); if (viewVisibility != View.VISIBLE || mNewSurfaceNeeded) { destroyHardwareResources(); @@ -1308,7 +1303,7 @@ public final class ViewRootImpl implements ViewParent, } // Execute enqueued actions on every traversal in case a detached view enqueued an action - getRunQueue().executeActions(attachInfo.mHandler); + getRunQueue().executeActions(mAttachInfo.mHandler); boolean insetsChanged = false; @@ -1364,21 +1359,21 @@ public final class ViewRootImpl implements ViewParent, if (collectViewAttributes()) { params = lp; } - if (attachInfo.mForceReportNewAttributes) { - attachInfo.mForceReportNewAttributes = false; + if (mAttachInfo.mForceReportNewAttributes) { + mAttachInfo.mForceReportNewAttributes = false; params = lp; } - if (mFirst || attachInfo.mViewVisibilityChanged) { - attachInfo.mViewVisibilityChanged = false; + if (mFirst || mAttachInfo.mViewVisibilityChanged) { + mAttachInfo.mViewVisibilityChanged = false; int resizeMode = mSoftInputMode & WindowManager.LayoutParams.SOFT_INPUT_MASK_ADJUST; // If we are in auto resize mode, then we need to determine // what mode to use now. if (resizeMode == WindowManager.LayoutParams.SOFT_INPUT_ADJUST_UNSPECIFIED) { - final int N = attachInfo.mScrollContainers.size(); + final int N = mAttachInfo.mScrollContainers.size(); for (int i=0; i