From ca0c18dc4cb68f55143cf97b053acae9ec8ecaed Mon Sep 17 00:00:00 2001 From: "Philip P. Moltmann" Date: Mon, 6 Jul 2020 14:45:14 -0700 Subject: [PATCH] Make pending intents of uninstall failure immutable They just link to settings. There is no need to modify them. On the other handle the package installer app has elevated powers, hence better restrict what can be launched with its powers. Test: Built Bug: 156011946 Change-Id: Ie78ec626235a9fd344d01075d08a072fa7a44e12 --- .../src/com/android/packageinstaller/UninstallFinish.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java b/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java index 5a51ac22b88f1..973ab8956304d 100644 --- a/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java +++ b/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java @@ -239,8 +239,8 @@ public class UninstallFinish extends BroadcastReceiver { builder.addAction((new Notification.Action.Builder( Icon.createWithResource(context, R.drawable.ic_settings_multiuser), context.getString(R.string.manage_users), - PendingIntent.getActivity(context, 0, intent, - PendingIntent.FLAG_UPDATE_CURRENT))).build()); + PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT + | PendingIntent.FLAG_IMMUTABLE))).build()); } /** @@ -259,7 +259,7 @@ public class UninstallFinish extends BroadcastReceiver { builder.addAction((new Notification.Action.Builder( Icon.createWithResource(context, R.drawable.ic_lock), context.getString(R.string.manage_device_administrators), - PendingIntent.getActivity(context, 0, intent, - PendingIntent.FLAG_UPDATE_CURRENT))).build()); + PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT + | PendingIntent.FLAG_IMMUTABLE))).build()); } }