From f18e567b2ab302895ffa021535c810e9111264fd Mon Sep 17 00:00:00 2001 From: Wilson Wu Date: Wed, 14 Apr 2021 14:50:30 +0800 Subject: [PATCH] Rename IInputMethodManager#reportPerceptible Rename this method to reportPerceptibleAsync for readability, because it was already a truly one-way method when it create. Bug: 185281885 Test: atest CtsInputMethodTestCases Change-Id: I9c72b980678f0310c79b293ea06f465e9ca1d760 --- core/java/android/view/inputmethod/InputMethodManager.java | 2 +- core/java/com/android/internal/view/IInputMethodManager.aidl | 2 +- .../android/server/inputmethod/InputMethodManagerService.java | 2 +- .../inputmethod/MultiClientInputMethodManagerService.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/java/android/view/inputmethod/InputMethodManager.java b/core/java/android/view/inputmethod/InputMethodManager.java index 6edd07178ed30..5121f5c1bc508 100644 --- a/core/java/android/view/inputmethod/InputMethodManager.java +++ b/core/java/android/view/inputmethod/InputMethodManager.java @@ -581,7 +581,7 @@ public final class InputMethodManager { */ public void reportPerceptible(IBinder windowToken, boolean perceptible) { try { - mService.reportPerceptible(windowToken, perceptible); + mService.reportPerceptibleAsync(windowToken, perceptible); } catch (RemoteException e) { throw e.rethrowFromSystemServer(); } diff --git a/core/java/com/android/internal/view/IInputMethodManager.aidl b/core/java/com/android/internal/view/IInputMethodManager.aidl index 50bbfc5ccb085..55b0b5c38550c 100644 --- a/core/java/com/android/internal/view/IInputMethodManager.aidl +++ b/core/java/com/android/internal/view/IInputMethodManager.aidl @@ -85,7 +85,7 @@ interface IInputMethodManager { oneway void reportActivityView(in IInputMethodClient parentClient, int childDisplayId, in float[] matrixValues, in IVoidResultCallback resultCallback); - oneway void reportPerceptible(in IBinder windowToken, boolean perceptible); + oneway void reportPerceptibleAsync(in IBinder windowToken, boolean perceptible); /** Remove the IME surface. Requires INTERNAL_SYSTEM_WINDOW permission. */ oneway void removeImeSurface(in IVoidResultCallback resultCallback); /** Remove the IME surface. Requires passing the currently focused window. */ diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java index ed8ea186b1d4b..0d0cc23812b22 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java @@ -3177,7 +3177,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub @BinderThread @Override - public void reportPerceptible(IBinder windowToken, boolean perceptible) { + public void reportPerceptibleAsync(IBinder windowToken, boolean perceptible) { Objects.requireNonNull(windowToken, "windowToken must not be null"); int uid = Binder.getCallingUid(); synchronized (mMethodMap) { diff --git a/services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java index ef1489b4adf9d..1f44fa3664ac8 100644 --- a/services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java @@ -1842,7 +1842,7 @@ public final class MultiClientInputMethodManagerService { @BinderThread @Override - public void reportPerceptible(IBinder windowClient, boolean perceptible) { + public void reportPerceptibleAsync(IBinder windowClient, boolean perceptible) { reportNotSupported(); }