From 258d9fc6c6cb803aa2721a9e2f884088b476cafe Mon Sep 17 00:00:00 2001 From: Adam Cohen Date: Sat, 13 Oct 2012 20:24:26 -0700 Subject: [PATCH] Fix inability to start pattern outside view bounds (issue 7344325) -> At the same time, disabling the abilit to page the widget region and see the overscroll effect Change-Id: Icd9d9e253404bfbfc411d8958f7c634ca4e37279 --- .../impl/keyguard/KeyguardWidgetRegion.java | 21 ++++++++++++------- .../policy/impl/keyguard/PagedView.java | 11 ++++++++++ 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetRegion.java b/policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetRegion.java index bd79d679dd6bd..4ff6f27302ce8 100644 --- a/policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetRegion.java +++ b/policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetRegion.java @@ -29,6 +29,9 @@ public class KeyguardWidgetRegion extends LinearLayout implements PagedView.Page private int mPage = 0; private Callbacks mCallbacks; + // We are disabling touch interaction of the widget region for factory ROM. + private static final boolean DISABLE_TOUCH_INTERACTION = true; + private static final long CUSTOM_WIDGET_USER_ACTIVITY_TIMEOUT = 30000; public KeyguardWidgetRegion(Context context) { @@ -52,19 +55,21 @@ public class KeyguardWidgetRegion extends LinearLayout implements PagedView.Page mPager.setPageSwitchListener(this); setSoundEffectsEnabled(false); - setOnClickListener(new OnClickListener() { - @Override - public void onClick(View v) { - showPagingFeedback(); - } - }); + if (!DISABLE_TOUCH_INTERACTION) { + setOnClickListener(new OnClickListener() { + @Override + public void onClick(View v) { + showPagingFeedback(); + } + }); + } } public void showPagingFeedback() { - if (true || (mPage < mPager.getPageCount() - 1)) { + if ((mPage < mPager.getPageCount() - 1)) { mLeftStrip.makeEmGo(); } - if (true || (mPage > 0)) { + if ((mPage > 0)) { mRightStrip.makeEmGo(); } } diff --git a/policy/src/com/android/internal/policy/impl/keyguard/PagedView.java b/policy/src/com/android/internal/policy/impl/keyguard/PagedView.java index d834741e5809d..d6fa586a5df9e 100644 --- a/policy/src/com/android/internal/policy/impl/keyguard/PagedView.java +++ b/policy/src/com/android/internal/policy/impl/keyguard/PagedView.java @@ -77,6 +77,9 @@ public class PagedView extends ViewGroup implements ViewGroup.OnHierarchyChangeL private static final int MIN_SNAP_VELOCITY = 1500; private static final int MIN_FLING_VELOCITY = 250; + // We are disabling touch interaction of the widget region for factory ROM. + private static final boolean DISABLE_TOUCH_INTERACTION = true; + static final int AUTOMATIC_PAGE_SPACING = -1; protected int mFlingThresholdVelocity; @@ -861,6 +864,10 @@ public class PagedView extends ViewGroup implements ViewGroup.OnHierarchyChangeL @Override public boolean onInterceptTouchEvent(MotionEvent ev) { + if (DISABLE_TOUCH_INTERACTION) { + return false; + } + /* * This method JUST determines whether we want to intercept the motion. * If we return true, onTouchEvent will be called and we do the actual @@ -1099,6 +1106,10 @@ public class PagedView extends ViewGroup implements ViewGroup.OnHierarchyChangeL @Override public boolean onTouchEvent(MotionEvent ev) { + if (DISABLE_TOUCH_INTERACTION) { + return false; + } + // Skip touch handling if there are no pages to swipe if (getChildCount() <= 0) return super.onTouchEvent(ev);