From 5082fd58e33aa54d760459de3368912c37864a4f Mon Sep 17 00:00:00 2001 From: Satish Roddom Date: Wed, 24 Jun 2009 05:10:24 -0500 Subject: [PATCH] frameworks/base: Update mPdu in createFromPdu Inside createFromPdu(), the passed-in parameter 'pdu' is assigned to msg.mPdu, so that we can call getPdu() to get it back. --- .../com/android/internal/telephony/cdma/SmsMessage.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java b/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java index 3a9206454e3d5..1b83e5cd32a3b 100644 --- a/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java +++ b/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java @@ -518,6 +518,7 @@ public class SmsMessage extends SmsMessageBase { originatingAddress = addr; env.origAddress = addr; mEnvelope = env; + mPdu = pdu; parseSms(); } @@ -728,9 +729,8 @@ public class SmsMessage extends SmsMessageBase { dos.close(); /** - * TODO(cleanup) -- This is the only place where mPdu is - * defined, and this is not obviously the only place where - * it needs to be defined. It would be much nicer if + * TODO(cleanup) -- The mPdu field is managed in + * a fragile manner, and it would be much nicer if * accessing the serialized representation used a less * fragile mechanism. Maybe the getPdu method could * generate a representation if there was not yet one?