Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix for Typeface.create(Typeface, style) semantics changed in KK" into klp-dev

Browse Source
This commit is contained in:
Victoria Lease
2013-11-06 19:30:22 +00:00
committed by Android (Google) Code Review
parent 04cead14b6 4f0064fa34
commit c89eaf916a
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/jni/android/graphics/Typeface.cpp
View File

@@ -34,6 +34,13 @@ static SkTypeface* Typeface_create(JNIEnv* env, jobject, jstring name,
if (NULL != name) {
AutoJavaStringToUTF8 str(env, name);
face = SkTypeface::CreateFromName(str.c_str(), style);
// Try to find the closest matching font, using the standard heuristic
if (NULL == face) {
face = SkTypeface::CreateFromName(str.c_str(), (SkTypeface::Style)(style ^ SkTypeface::kItalic));
}
for (int i = 0; NULL == face && i < 4; i++) {
face = SkTypeface::CreateFromName(str.c_str(), (SkTypeface::Style)i);
}
}
// return the default font at the best style if no exact match exists
@@ -45,8 +52,13 @@ static SkTypeface* Typeface_create(JNIEnv* env, jobject, jstring name,
static SkTypeface* Typeface_createFromTypeface(JNIEnv* env, jobject, SkTypeface* family, int style) {
SkTypeface* face = SkTypeface::CreateFromTypeface(family, (SkTypeface::Style)style);
// return the default font at the best style if the requested style does not
// exist in the provided family
// Try to find the closest matching font, using the standard heuristic
if (NULL == face) {
face = SkTypeface::CreateFromTypeface(family, (SkTypeface::Style)(style ^ SkTypeface::kItalic));
}
for (int i = 0; NULL == face && i < 4; i++) {
face = SkTypeface::CreateFromTypeface(family, (SkTypeface::Style)i);
}
if (NULL == face) {
face = SkTypeface::CreateFromName(NULL, (SkTypeface::Style)style);
}