From 847be7445e15851c460bf381d7083c443d8d6144 Mon Sep 17 00:00:00 2001 From: Adam Powell Date: Tue, 11 Dec 2012 15:41:17 -0800 Subject: [PATCH] Fix regression in ListView click handling Regression caused by patch a607223f34 If an item click handler results in the ListView becoming detached from the window, the performClick runnable could be executed twice. Null out the mTouchModeReset runnable before running the click handler so that it is not run by the detach handler. Change-Id: I2fab60232027bb4876f9912088e0ffb9b17d308c --- core/java/android/widget/AbsListView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/widget/AbsListView.java b/core/java/android/widget/AbsListView.java index a6b7dba784411..57bf0d3aee923 100644 --- a/core/java/android/widget/AbsListView.java +++ b/core/java/android/widget/AbsListView.java @@ -3416,13 +3416,13 @@ public abstract class AbsListView extends AdapterView implements Te mTouchModeReset = new Runnable() { @Override public void run() { + mTouchModeReset = null; mTouchMode = TOUCH_MODE_REST; child.setPressed(false); setPressed(false); if (!mDataChanged) { performClick.run(); } - mTouchModeReset = null; } }; postDelayed(mTouchModeReset,