Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 9071 into donut

Browse Source 
* changes:
  Fix issue #2018454: NullPointerException in ImageSpan constructor
This commit is contained in:
Android (Google) Code Review
2009-07-29 18:09:28 -07:00
parent 9c71716e3d 0cd6376fa1
commit c6eb5ac988
2 changed files with 46 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
api/current.xml
View File

@@ -130438,6 +130438,28 @@
deprecated="not deprecated"
visibility="public"
>
<constructor name="ImageSpan"
type="android.text.style.ImageSpan"
static="false"
final="false"
deprecated="deprecated"
visibility="public"
>
<parameter name="b" type="android.graphics.Bitmap">
</parameter>
</constructor>
<constructor name="ImageSpan"
type="android.text.style.ImageSpan"
static="false"
final="false"
deprecated="deprecated"
visibility="public"
>
<parameter name="b" type="android.graphics.Bitmap">
</parameter>
<parameter name="verticalAlignment" type="int">
</parameter>
</constructor>
<constructor name="ImageSpan"
type="android.text.style.ImageSpan"
static="false"
@@ -130445,6 +130467,8 @@
deprecated="not deprecated"
visibility="public"
>
<parameter name="context" type="android.content.Context">
</parameter>
<parameter name="b" type="android.graphics.Bitmap">
</parameter>
</constructor>
@@ -130455,6 +130479,8 @@
deprecated="not deprecated"
visibility="public"
>
<parameter name="context" type="android.content.Context">
</parameter>
<parameter name="b" type="android.graphics.Bitmap">
</parameter>
<parameter name="verticalAlignment" type="int">

23
core/java/android/text/style/ImageSpan.java
View File

@@ -33,17 +33,34 @@ public class ImageSpan extends DynamicDrawableSpan {
private Context mContext;
private String mSource;
/**
* @deprecated Use {@link #ImageSpan(Context, Bitmap)} instead.
*/
public ImageSpan(Bitmap b) {
this(b, ALIGN_BOTTOM);
this(null, b, ALIGN_BOTTOM);
}
/**
* @deprecated Use {@link #ImageSpan(Context, Bitmap, int) instead.
*/
public ImageSpan(Bitmap b, int verticalAlignment) {
this(null, b, verticalAlignment);
}
public ImageSpan(Context context, Bitmap b) {
this(context, b, ALIGN_BOTTOM);
}
/**
* @param verticalAlignment one of {@link DynamicDrawableSpan#ALIGN_BOTTOM} or
* {@link DynamicDrawableSpan#ALIGN_BASELINE}.
*/
public ImageSpan(Bitmap b, int verticalAlignment) {
public ImageSpan(Context context, Bitmap b, int verticalAlignment) {
super(verticalAlignment);
mDrawable = new BitmapDrawable(mContext.getResources(), b);
mContext = context;
mDrawable = context != null
? new BitmapDrawable(context.getResources(), b)
: new BitmapDrawable(b);
int width = mDrawable.getIntrinsicWidth();
int height = mDrawable.getIntrinsicHeight();
mDrawable.setBounds(0, 0, width > 0 ? width : 0, height > 0 ? height : 0);