Merge change If2fdad3b into eclair

* changes:
  Add a warning when we leave threads in the binder thread pool in the background scheduling group.
This commit is contained in:
Android (Google) Code Review
2009-11-03 16:29:22 -05:00

View File

@@ -14,10 +14,13 @@
* limitations under the License.
*/
#define LOG_TAG "IPCThreadState"
#include <binder/IPCThreadState.h>
#include <binder/Binder.h>
#include <binder/BpBinder.h>
#include <cutils/sched_policy.h>
#include <utils/Debug.h>
#include <utils/Log.h>
#include <utils/TextOutput.h>
@@ -418,7 +421,32 @@ void IPCThreadState::joinThreadPool(bool isMain)
alog << "Processing top-level Command: "
<< getReturnString(cmd) << endl;
}
bool isTainted = false;
{
SchedPolicy policy;
get_sched_policy(getpid(), &policy);
if (policy == SP_BACKGROUND) {
isTainted = true;
}
}
result = executeCommand(cmd);
// Make sure that after executing the commands that we put the thread back into the
// default cgroup.
{
int pid = getpid();
SchedPolicy policy;
get_sched_policy(pid, &policy);
if (!isTainted && policy == SP_BACKGROUND) {
LOGW("*** THREAD %p (PID %p) was left in SP_BACKGROUND with a priority of %d\n",
(void*)pthread_self(), pid, getpriority(PRIO_PROCESS, pid));
}
}
}
// Let this thread exit the thread pool if it is no longer