From 6aea00afbe4683e443d82d7c8e42d1753d71bfb6 Mon Sep 17 00:00:00 2001 From: Nataniel Borges Date: Thu, 10 Nov 2022 11:55:34 +0000 Subject: [PATCH 1/2] Compatibilize flicker tests with flicker infra refactor Rename FlickerTestParameter(Factory) to FlickerTest(Factory) Rename testSpec to flicker Update factory method naming Fix imports Fix ktfmt formatting issues Remove launcher strategy from helpers Bug: 255715397 Test: atest FlickerTests WMShellFlickerTests Change-Id: If0143ae3d94fd78a8339a69287072b3edbbbaca1 --- .../Shell/tests/flicker/AndroidTest.xml | 2 + .../com/android/wm/shell/flicker/BaseTest.kt | 45 ++-- .../wm/shell/flicker/CommonAssertions.kt | 100 +++++---- .../shell/flicker/bubble/BaseBubbleScreen.kt | 21 +- .../flicker/bubble/DismissBubbleScreen.kt | 10 +- .../flicker/bubble/ExpandBubbleScreen.kt | 10 +- .../bubble/LaunchBubbleFromLockScreen.kt | 10 +- .../flicker/bubble/LaunchBubbleScreen.kt | 10 +- .../flicker/bubble/MultiBubblesScreen.kt | 10 +- .../bubble/MultiBubblesScreenShellTransit.kt | 7 +- .../flicker/pip/AutoEnterPipOnGoToHomeTest.kt | 16 +- .../pip/EnterPipOnUserLeaveHintTest.kt | 22 +- .../wm/shell/flicker/pip/EnterPipTest.kt | 41 ++-- .../pip/EnterPipToOtherOrientationTest.kt | 122 +++++------ .../flicker/pip/ExitPipToAppTransition.kt | 18 +- .../wm/shell/flicker/pip/ExitPipTransition.kt | 16 +- .../pip/ExitPipViaExpandButtonClickTest.kt | 48 ++--- .../shell/flicker/pip/ExitPipViaIntentTest.kt | 27 ++- .../pip/ExitPipWithDismissButtonTest.kt | 23 ++- .../flicker/pip/ExitPipWithSwipeDownTest.kt | 25 +-- .../flicker/pip/ExpandPipOnDoubleClickTest.kt | 90 +++----- .../flicker/pip/ExpandPipOnPinchOpenTest.kt | 39 ++-- .../pip/MovePipDownShelfHeightChangeTest.kt | 55 ++--- .../pip/MovePipShelfHeightTransition.kt | 17 +- .../pip/MovePipUpShelfHeightChangeTest.kt | 61 +++--- .../wm/shell/flicker/pip/PipKeyboardTest.kt | 25 +-- .../pip/PipKeyboardTestShellTransit.kt | 6 +- .../wm/shell/flicker/pip/PipRotationTest.kt | 51 +++-- .../pip/PipRotationTest_ShellTransit.kt | 8 +- .../wm/shell/flicker/pip/PipTransition.kt | 8 +- .../SetRequestedOrientationWhilePinnedTest.kt | 84 ++++---- .../flicker/splitscreen/CopyContentInSplit.kt | 46 ++--- .../DismissSplitScreenByDivider.kt | 92 ++++----- .../splitscreen/DismissSplitScreenByGoHome.kt | 82 ++++---- .../splitscreen/DragDividerToResize.kt | 102 ++++----- .../EnterSplitScreenByDragFromAllApps.kt | 89 ++++---- .../EnterSplitScreenByDragFromNotification.kt | 86 ++++---- .../EnterSplitScreenByDragFromShortcut.kt | 87 ++++---- .../EnterSplitScreenByDragFromTaskbar.kt | 86 ++++---- .../EnterSplitScreenFromOverview.kt | 79 +++---- .../flicker/splitscreen/SplitScreenBase.kt | 10 +- .../flicker/splitscreen/SplitScreenUtils.kt | 16 +- .../SwitchAppByDoubleTapDivider.kt | 193 +++++++++--------- .../SwitchBackToSplitFromAnotherApp.kt | 44 ++-- .../splitscreen/SwitchBackToSplitFromHome.kt | 44 ++-- .../SwitchBackToSplitFromRecent.kt | 44 ++-- .../splitscreen/SwitchBetweenSplitPairs.kt | 88 ++++---- tests/FlickerTests/AndroidTest.xml | 2 + .../com/android/server/wm/flicker/BaseTest.kt | 41 ++-- .../server/wm/flicker/CommonAssertions.kt | 56 ++--- .../ActivityEmbeddingTestBase.kt | 4 +- .../OpenActivityEmbeddingPlaceholderSplit.kt | 36 ++-- .../flicker/close/CloseAppBackButtonTest.kt | 18 +- .../flicker/close/CloseAppHomeButtonTest.kt | 21 +- .../wm/flicker/close/CloseAppTransition.kt | 18 +- .../helpers/ActivityEmbeddingAppHelper.kt | 8 +- .../wm/flicker/helpers/AssistantAppHelper.kt | 41 ++-- .../helpers/FixedOrientationAppHelper.kt | 8 +- .../wm/flicker/helpers/FlickerExtensions.kt | 4 +- .../wm/flicker/helpers/GameAppHelper.kt | 8 +- .../flicker/helpers/ImeAppAutoFocusHelper.kt | 2 +- .../server/wm/flicker/helpers/ImeAppHelper.kt | 8 +- .../helpers/ImeStateInitializeHelper.kt | 8 +- .../wm/flicker/helpers/MailAppHelper.kt | 8 +- .../wm/flicker/helpers/NewTasksAppHelper.kt | 8 +- .../flicker/helpers/NonResizeableAppHelper.kt | 8 +- .../flicker/helpers/NotificationAppHelper.kt | 8 +- .../server/wm/flicker/helpers/PipAppHelper.kt | 8 +- .../helpers/SeamlessRotationAppHelper.kt | 8 +- .../helpers/ShowWhenLockedAppHelper.kt | 8 +- .../wm/flicker/helpers/SimpleAppHelper.kt | 8 +- .../flicker/helpers/TwoActivitiesAppHelper.kt | 8 +- .../ime/CloseImeAutoOpenWindowToAppTest.kt | 43 ++-- .../ime/CloseImeAutoOpenWindowToHomeTest.kt | 43 ++-- .../ime/CloseImeEditorPopupDialogTest.kt | 29 ++- .../wm/flicker/ime/CloseImeWindowToAppTest.kt | 34 +-- .../flicker/ime/CloseImeWindowToHomeTest.kt | 41 ++-- .../server/wm/flicker/ime/CommonAssertions.kt | 12 +- .../LaunchAppShowImeAndDialogThemeAppTest.kt | 47 +++-- .../ime/LaunchAppShowImeOnStartTest.kt | 53 +++-- .../flicker/ime/OpenImeWindowAndCloseTest.kt | 33 ++- ...penImeWindowFromFixedOrientationAppTest.kt | 44 ++-- .../wm/flicker/ime/OpenImeWindowTest.kt | 37 ++-- .../ime/OpenImeWindowToOverViewTest.kt | 105 +++++----- .../wm/flicker/ime/ReOpenImeWindowTest.kt | 47 +++-- .../ime/SwitchImeWindowsFromGestureNavTest.kt | 37 ++-- ...eWindowsFromGestureNavTest_ShellTransit.kt | 19 +- .../launch/ActivitiesTransitionTest.kt | 26 +-- .../flicker/launch/OpenAppAfterCameraTest.kt | 19 +- .../OpenAppAfterCameraTest_ShellTransit.kt | 7 +- .../wm/flicker/launch/OpenAppColdFromIcon.kt | 33 ++- .../wm/flicker/launch/OpenAppColdTest.kt | 21 +- .../launch/OpenAppFromLauncherTransition.kt | 25 ++- .../launch/OpenAppFromLockNotificationCold.kt | 25 +-- .../launch/OpenAppFromLockNotificationWarm.kt | 25 ++- ...pFromLockNotificationWithLockOverlayApp.kt | 27 ++- .../launch/OpenAppFromLockTransition.kt | 27 ++- .../launch/OpenAppFromNotificationCold.kt | 32 ++- .../launch/OpenAppFromNotificationWarm.kt | 47 +++-- .../flicker/launch/OpenAppFromOverviewTest.kt | 25 ++- .../launch/OpenAppNonResizeableTest.kt | 69 +++---- .../wm/flicker/launch/OpenAppTransition.kt | 22 +- .../wm/flicker/launch/OpenAppWarmTest.kt | 21 +- .../launch/OverrideTaskTransitionTest.kt | 50 ++--- .../wm/flicker/launch/TaskTransitionTest.kt | 28 +-- .../QuickSwitchBetweenTwoAppsBackTest.kt | 53 +++-- ...itchBetweenTwoAppsBackTest_ShellTransit.kt | 19 +- .../QuickSwitchBetweenTwoAppsForwardTest.kt | 54 +++-- ...hBetweenTwoAppsForwardTest_ShellTransit.kt | 19 +- .../QuickSwitchFromLauncherTest.kt | 90 ++++---- .../flicker/rotation/ChangeAppRotationTest.kt | 26 +-- .../wm/flicker/rotation/RotationTransition.kt | 16 +- .../rotation/SeamlessAppRotationTest.kt | 81 ++++---- 113 files changed, 1884 insertions(+), 2197 deletions(-) diff --git a/libs/WindowManager/Shell/tests/flicker/AndroidTest.xml b/libs/WindowManager/Shell/tests/flicker/AndroidTest.xml index 08913c6fde53a..27fc381a10d12 100644 --- a/libs/WindowManager/Shell/tests/flicker/AndroidTest.xml +++ b/libs/WindowManager/Shell/tests/flicker/AndroidTest.xml @@ -19,6 +19,8 @@