From 21ff4018c902dfb20393abeafd3e6adfa6fa50b1 Mon Sep 17 00:00:00 2001 From: Yuri Lin Date: Mon, 10 Oct 2022 16:10:36 -0400 Subject: [PATCH] Detect dismissals on the lockscreen surface When users dismiss notifications from the lockscreen, they're currently getting attributed to being dismissed from the shade. This change distinguishes lockscreen dismissals from shade dismissals for more specific and accurate metrics. (These dismissal surfaces are already translated to cancellation reasons in NotificationRecordLogger.) Bug: 234507856 Test: statsd_testdrive Change-Id: I80539025e2d4d7bacbcda59133a85d06d4690a35 --- .../collection/inflation/OnUserInteractionCallbackImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/inflation/OnUserInteractionCallbackImpl.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/inflation/OnUserInteractionCallbackImpl.java index a7719d3d82a4b..e71d80c130dac 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/inflation/OnUserInteractionCallbackImpl.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/inflation/OnUserInteractionCallbackImpl.java @@ -18,6 +18,8 @@ package com.android.systemui.statusbar.notification.collection.inflation; import static android.service.notification.NotificationStats.DISMISS_SENTIMENT_NEUTRAL; +import static com.android.systemui.statusbar.StatusBarState.KEYGUARD; + import android.os.SystemClock; import android.service.notification.NotificationStats; @@ -70,6 +72,8 @@ public class OnUserInteractionCallbackImpl implements OnUserInteractionCallback dismissalSurface = NotificationStats.DISMISSAL_PEEK; } else if (mStatusBarStateController.isDozing()) { dismissalSurface = NotificationStats.DISMISSAL_AOD; + } else if (mStatusBarStateController.getState() == KEYGUARD) { + dismissalSurface = NotificationStats.DISMISSAL_LOCKSCREEN; } return new DismissedByUserStats( dismissalSurface,