Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace buildTemplate* with NetworkTemplate.Builder

Browse Source 
NetworkTemplate is going to be moved into mainline module so the
hidden APIs cannot be used anymore.
Therefore, use NetworkTemplate.Builder to create the template
instead.

Bug: 210073043
Test: atest BytesTransferredTest
Change-Id: I5d84d13a75dbafb286e9754421ed17f52c6e22b9
This commit is contained in:
Aaron Huang
2021-12-27 16:21:58 +08:00
parent 9278335f3c
commit c46661ee0d
1 changed files with 28 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
services/core/java/com/android/server/stats/pull/StatsPullAtomService.java
View File

@@ -28,18 +28,11 @@ import static android.net.NetworkCapabilities.TRANSPORT_ETHERNET;
import static android.net.NetworkCapabilities.TRANSPORT_WIFI; import static android.net.NetworkCapabilities.TRANSPORT_WIFI;
import static android.net.NetworkIdentity.OEM_PAID; import static android.net.NetworkIdentity.OEM_PAID;
import static android.net.NetworkIdentity.OEM_PRIVATE; import static android.net.NetworkIdentity.OEM_PRIVATE;
import static android.net.NetworkStats.DEFAULT_NETWORK_ALL;
import static android.net.NetworkStats.METERED_ALL;
import static android.net.NetworkStats.METERED_YES; import static android.net.NetworkStats.METERED_YES;
import static android.net.NetworkStats.ROAMING_ALL;
import static android.net.NetworkTemplate.MATCH_ETHERNET; import static android.net.NetworkTemplate.MATCH_ETHERNET;
import static android.net.NetworkTemplate.MATCH_MOBILE_WILDCARD; import static android.net.NetworkTemplate.MATCH_MOBILE;
import static android.net.NetworkTemplate.MATCH_WIFI_WILDCARD; import static android.net.NetworkTemplate.MATCH_WIFI;
import static android.net.NetworkTemplate.NETWORK_TYPE_ALL;
import static android.net.NetworkTemplate.OEM_MANAGED_ALL; import static android.net.NetworkTemplate.OEM_MANAGED_ALL;
import static android.net.NetworkTemplate.buildTemplateMobileWildcard;
import static android.net.NetworkTemplate.buildTemplateMobileWithRatType;
import static android.net.NetworkTemplate.buildTemplateWifiWildcard;
import static android.net.NetworkTemplate.getAllCollapsedRatTypes; import static android.net.NetworkTemplate.getAllCollapsedRatTypes;
import static android.os.Debug.getIonHeapsSizeKb; import static android.os.Debug.getIonHeapsSizeKb;
import static android.os.Process.LAST_SHARED_APPLICATION_GID; import static android.os.Process.LAST_SHARED_APPLICATION_GID;
@@ -1179,9 +1172,10 @@ public class StatsPullAtomService extends SystemService {
} }
case FrameworkStatsLog.BYTES_TRANSFER_BY_TAG_AND_METERED: { case FrameworkStatsLog.BYTES_TRANSFER_BY_TAG_AND_METERED: {
final NetworkStats wifiStats = getUidNetworkStatsSnapshotForTemplate( final NetworkStats wifiStats = getUidNetworkStatsSnapshotForTemplate(
buildTemplateWifiWildcard(), /*includeTags=*/true); new NetworkTemplate.Builder(MATCH_WIFI).build(), /*includeTags=*/true);
final NetworkStats cellularStats = getUidNetworkStatsSnapshotForTemplate( final NetworkStats cellularStats = getUidNetworkStatsSnapshotForTemplate(
buildTemplateMobileWildcard(), /*includeTags=*/true); new NetworkTemplate.Builder(MATCH_MOBILE)
.setMeteredness(METERED_YES).build(), /*includeTags=*/true);
if (wifiStats != null && cellularStats != null) { if (wifiStats != null && cellularStats != null) {
final NetworkStats stats = wifiStats.add(cellularStats); final NetworkStats stats = wifiStats.add(cellularStats);
ret.add(new NetworkStatsExt(sliceNetworkStatsByUidTagAndMetered(stats), ret.add(new NetworkStatsExt(sliceNetworkStatsByUidTagAndMetered(stats),
@@ -1333,8 +1327,8 @@ public class StatsPullAtomService extends SystemService {
@NonNull private List<NetworkStatsExt> getDataUsageBytesTransferSnapshotForOemManaged() { @NonNull private List<NetworkStatsExt> getDataUsageBytesTransferSnapshotForOemManaged() {
final List<Pair<Integer, Integer>> matchRulesAndTransports = List.of( final List<Pair<Integer, Integer>> matchRulesAndTransports = List.of(
new Pair(MATCH_ETHERNET, TRANSPORT_ETHERNET), new Pair(MATCH_ETHERNET, TRANSPORT_ETHERNET),
new Pair(MATCH_MOBILE_WILDCARD, TRANSPORT_CELLULAR), new Pair(MATCH_MOBILE, TRANSPORT_CELLULAR),
new Pair(MATCH_WIFI_WILDCARD, TRANSPORT_WIFI) new Pair(MATCH_WIFI, TRANSPORT_WIFI)
); );
final int[] oemManagedTypes = new int[] {OEM_PAID | OEM_PRIVATE, OEM_PAID, OEM_PRIVATE}; final int[] oemManagedTypes = new int[] {OEM_PAID | OEM_PRIVATE, OEM_PAID, OEM_PRIVATE};
@@ -1343,12 +1337,11 @@ public class StatsPullAtomService extends SystemService {
for (Pair<Integer, Integer> ruleAndTransport : matchRulesAndTransports) { for (Pair<Integer, Integer> ruleAndTransport : matchRulesAndTransports) {
final Integer matchRule = ruleAndTransport.first; final Integer matchRule = ruleAndTransport.first;
for (final int oemManaged : oemManagedTypes) { for (final int oemManaged : oemManagedTypes) {
/* A null subscriberId will set wildcard=true, since we aren't trying to select a // Subscriber Ids and Wifi Network Keys will not be set since the purpose is to
specific ssid or subscriber. */ // slice statistics of different OEM managed networks among all network types.
final NetworkTemplate template = new NetworkTemplate(matchRule, // Thus, specifying networks through their identifiers are not needed.
/*subscriberId=*/null, /*matchSubscriberIds=*/null, /*networkId=*/null, final NetworkTemplate template = new NetworkTemplate.Builder(matchRule)
METERED_ALL, ROAMING_ALL, DEFAULT_NETWORK_ALL, NETWORK_TYPE_ALL, .setOemManaged(oemManaged).build();
oemManaged);
final NetworkStats stats = getUidNetworkStatsSnapshotForTemplate(template, false); final NetworkStats stats = getUidNetworkStatsSnapshotForTemplate(template, false);
final Integer transport = ruleAndTransport.second; final Integer transport = ruleAndTransport.second;
if (stats != null) { if (stats != null) {
@@ -1367,10 +1360,18 @@ public class StatsPullAtomService extends SystemService {
* Create a snapshot of NetworkStats for a given transport. * Create a snapshot of NetworkStats for a given transport.
*/ */
@Nullable private NetworkStats getUidNetworkStatsSnapshotForTransport(int transport) { @Nullable private NetworkStats getUidNetworkStatsSnapshotForTransport(int transport) {
final NetworkTemplate template = (transport == TRANSPORT_CELLULAR) NetworkTemplate template = null;
? NetworkTemplate.buildTemplateMobileWithRatType( switch (transport) {
/*subscriptionId=*/null, NETWORK_TYPE_ALL, METERED_YES) case TRANSPORT_CELLULAR:
: NetworkTemplate.buildTemplateWifiWildcard(); template = new NetworkTemplate.Builder(MATCH_MOBILE)
.setMeteredness(METERED_YES).build();
break;
case TRANSPORT_WIFI:
template = new NetworkTemplate.Builder(MATCH_WIFI).build();
break;
default:
Log.wtf(TAG, "Unexpected transport.");
}
return getUidNetworkStatsSnapshotForTemplate(template, /*includeTags=*/false); return getUidNetworkStatsSnapshotForTemplate(template, /*includeTags=*/false);
} }
@@ -1409,8 +1410,10 @@ public class StatsPullAtomService extends SystemService {
final List<NetworkStatsExt> ret = new ArrayList<>(); final List<NetworkStatsExt> ret = new ArrayList<>();
for (final int ratType : getAllCollapsedRatTypes()) { for (final int ratType : getAllCollapsedRatTypes()) {
final NetworkTemplate template = final NetworkTemplate template =
buildTemplateMobileWithRatType(subInfo.subscriberId, ratType, new NetworkTemplate.Builder(MATCH_MOBILE)
METERED_YES); .setSubscriberIds(Set.of(subInfo.subscriberId))
.setRatType(ratType)
.setMeteredness(METERED_YES).build();
final NetworkStats stats = final NetworkStats stats =
getUidNetworkStatsSnapshotForTemplate(template, /*includeTags=*/false); getUidNetworkStatsSnapshotForTemplate(template, /*includeTags=*/false);
if (stats != null) { if (stats != null) {